Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create peg:oops-mod #104

Closed
wants to merge 1 commit into from
Closed

Create peg:oops-mod #104

wants to merge 1 commit into from

Conversation

noah-severyn
Copy link
Contributor

Also this would be good to add to the list of standard installed dependencies for testing. It is great for troubleshooting brown boxes.

@noah-severyn
Copy link
Contributor Author

Actually on second thought this would be better to have in the default channel.

@noah-severyn noah-severyn deleted the oops-mod branch January 25, 2025 02:17
@sebamarynissen
Copy link
Owner

Ah yes, definitely makes sense in the default channel. Let me know when it's there and I'll add it to the default mods installed with the npm run sc4pac command. I'm also thinking of maybe putting additional default packages in an environment variable in the .env file so that you can configure what packages you want to have installed by default.

@noah-severyn
Copy link
Contributor Author

Ah yes, definitely makes sense in the default channel. Let me know when it's there and I'll add it to the default mods installed with the npm run sc4pac command. I'm also thinking of maybe putting additional default packages in an environment variable in the .env file so that you can configure what packages you want to have installed by default.

That sounds like a good idea. Already merged with memo33/sc4pac#76.

sebamarynissen added a commit that referenced this pull request Jan 26, 2025
@sebamarynissen
Allow additional standard deps in .env
e729744 
See #104. This allows additional standard dependencies to be specified in the `.env` file under the `STANDARD_DEPENDENCIES` variable.
@sebamarynissen sebamarynissen mentioned this pull request Jan 26, 2025
Merged
sebamarynissen added a commit that referenced this pull request Jan 26, 2025
@sebamarynissen
feat: allow additional standard dependencies in .env (#109)
4b6ffbe 
* Update standard-deps.js

* Allow additional standard deps in .env

See #104. This allows additional standard dependencies to be specified in the `.env` file under the `STANDARD_DEPENDENCIES` variable.

* Accept default variants as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noah-severyn @sebamarynissen