Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMakeLists.txt #7

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix CMakeLists.txt #7

wants to merge 2 commits into from

Conversation

Shimmen
Copy link

@Shimmen Shimmen commented Feb 4, 2024

I found some issues with the CMakeLists.txt build script which I fixed:

  1. According to Google there is no CMake function/macro called setup_target_libs, and CMake (recent version) fails when executing the CMakeLists.txt script. It might be an artefact from the project this was originally created for(?). Either way, this pull request simply removes that line.
  2. The project did not have any include directories specified, so if you added the project with target_link_libraries(MyTarget offsetAllocator) the header would not be identified. Adding the call to target_include_directories fixes this.

Thanks!

// Simon

According to Google there is no such CMake function/macro...
@Shimmen Shimmen marked this pull request as draft February 4, 2024 21:47
@Shimmen Shimmen changed the title Remove call to invalid setup_target_libs CMake function/macro Fix CMakeLists.txt Feb 4, 2024
@Shimmen Shimmen marked this pull request as ready for review February 4, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant