Open
Conversation
Signed-off-by: Gordon Messmer <gmessmer@redhat.com>
gordonmessmer
force-pushed
the
versioned-symbols
branch
from
8801806 to
1f821c4
Compare
pcmoore
changed the title
Member
|
Hi @gordonmessmer, thanks for the patch! Considering the patch, it would be helpful to provide a description of the work in the patch's description. We also generally expect a subject prefix, e.g. "build: add versioned symbol support" for patches so it is easier to filter through patches when looking at the output from |
pcmoore
reviewed
Apr 8, 2026
| # FIXME: The test below returns a false positive for mingw | ||
| # cross-compiles, 'local:' statements does not reduce number of | ||
| # exported symbols in a DLL. Use --disable-ld-version-script to work | ||
| # around the problem. |
Member
There was a problem hiding this comment.
Is there a fix for this, or is this a known problem that is expected to have a solution at some later date?
|
|
||
| # gl_LD_VERSION_SCRIPT | ||
| # -------------------- | ||
| # Check if LD supports linker scripts, and define automake conditional |
Member
There was a problem hiding this comment.
Are there any (modern) versions of LD that don't support linker scripts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to improve reliable dependency resolution, I would like to add versioned symbols to the libraries that do not include them today.
This change is intended to support Fedora's recommendation that shared libraries provide versioned symbols: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/#_versioned_symbols
Please double-check the symbol files. If any symbols have been added very recently, they might not be in the symbol maps I've generated.