Skip to content

Conversation

marchcat
Copy link
Contributor

@marchcat marchcat commented Feb 12, 2025

Included features:
#3422
#3423

as of = 2025-05-13 for PV deploy
build = https://github.com/secondlife/viewer/releases/tag/Second_Life_Project_Lua_Editor%233af711e
cohort = Lua.Editor
deployed = https://github.com/secondlife/viewer/releases/tag/Second_Life_Project_Lua_Editor%233af711e
desired = 0
relnotes:

Second Life - SLua Editor Alpha

Server-side Lua is here!

This release adds support for disabling syntax highlighting from a debug setting: ScriptEditorDisableSyntaxHighlight

Please see the following page for information on where and how to use Lua in Second Life: https://wiki.secondlife.com/wiki/Luau_Alpha

Note: that pre-existing scripts may require being recompiled due to recent Server fixes.

Help Us Keep Improving!

Help us shape the future of Second Life! Found a bug or have feedback? Please submit it via our [Feedback Portal](https://feedback.secondlife.com/).

Thanks for being a vital part of the Second Life journey. We can’t wait to see what you create with these latest enhancements!

LLGuru and others added 30 commits January 25, 2025 03:02
Fix disabling renderdoc support
Improve ll_aligned_alloc functions on darwin for 32 and 64byte aligned by utilizing posix_memalign
RyeMutt and others added 23 commits September 5, 2025 19:35
Fix macos build arch and deploy target due to cmake behavior changes
when opening picker for the first time
Temporary switch to windows 2022, latest 2025 doesn't have nsis
Improvements found in reviewing mac_arm branch #4629
* Remove GLM sse flag from cmake that was moved to llpreprocessor.h

* Further reduce performance loss of HDR and Sharpening on bandwith-constrained gpu by combining gamma correction into tonemap/sharpening shader passes

* Update SSE2NEON to 1.8.0 to fix random render nans

* Fix occasional startup crash from LLCachedControl being declared in global scope
Temporary until we can better parallelize architecture specific builds.
…ging/re-plugging devices (#4593)

* [WebRTC] Rework device handling sequence so that we can handle unplugging/re-plugging devices

The device handling was not processing device updates in the proper sequence as
things like AEC use both input and output devices.  Devices like headsets are both
so unplugging them resulted in various mute conditions and sometimes even a crash.

Now, we update both capture and render devices at once in the proper sequence.

Test Guidance:
* Bring two users in the same place in webrtc regions.
* The 'listening' one should have a headset or something set oas 'Default'
* Press 'talk' on one, and verify the other can hear.
* Unplug the headset from the listening one.
* Validate that audio changes from the headset to the speakers.
* Plug the headset back in.
* Validate that audio changes from speakers to headset.
* Do the same type of test with the headset viewer talking.
* The microphone used should switch from the headset to the computer (it should have one)

Do other various device tests, such as setting devices explicitly, messing with the device selector, etc.

* Fix race condition when multiple change device requests might come in at once

* Update to m137

The primary feature of this commit is to update libwebrtc from m114
to m137.  This is needed to make webrtc buildable, as m114 is not buildable
by the current toolset.

m137 had some changes to the API, which required renaming or changing namespace
of some of the calls.

Additionally, this PR moves from a callback mechanism for gathering the energy
levels for tuning to a wrapper AudioDeviceModule, which gives us more control
over the audio stream.

Finally, the new m137-based webrtc has been updated to allow for 192khz audio
streams.

* Properly pass the observer setting into the inner audio device module

* Update to m137 and get rid of some noise

    This change updates to m137 from m114, which required a few API changes.

    Additionally, this fixes the hiss that happens shortly after someone unmutes: secondlife/server#2094

    There was also an issue with a slight amount of repeated after unmuting if there was audio right before unmuting.  This is because
    the audio processing and buffering still had audio from the previous speaking session.  Now, we inject nearly a half second of
    silence into the audio buffers/processor after unmuting to flush things.

* Install nsis on windows

* Use the newer digital AGC pipeline

m137 improved the AGC pipeline and the existing analog style is going away
so move to the new digital pipeline.

Also, some tweaking for audio levels so that we don't see inworld bars when tuning,
so one's own bars seem a reasonable size, etc.

* Install NSIS during windows sisgning and package build step

* Try pinning the packaging to windows 2022 to deal with missing nsis

* Adjust gain calculation and audio level calculations for tuning and peer connections

* Update with mac universal webrtc build

* Tuning of voice indicators for both tuning mode and inworld for self.

* Redo device deployment to handle cases where multiple deploy requests pile up

Also, mute when leaving webrtc-enabled regions or parcels,
and unmute when voice comes back.

* pre commit issue
isSystemMemoryLow() and factor check were too agressive for draw range.
resume() was trigggering sOnCurrentChannelChanged which was wiping
participant list with no follow up updates.
* Fix indexing problem with mac devices

This resulted in the wrong device being selected.

Also, fix a shutdown crash where recording was not being stopped, hence the recording
thread was still running on shutdown and crashed because it lost access to resources.

Fix an issue with p2p calls where they're coming up muted even though the button indicates
they are unmuted.

* Always refresh device list on notification of device changes

Even when the selected device doesn't change, we need to
re-deploy it as it might have had characteristics (sampling rate, etc.) changed.

Also, we need to redeploy when the Default device has changed
for diagnostic purposes
Cleanup is in LLVoiceClient::terminate()
gWebRTCImpl was never deleted
Added mDeviceModule security
Copy link

github-actions bot commented Oct 3, 2025


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


13 out of 14 committers have signed the CLA.
✅ (LLGuru)[https://github.com/LLGuru]
✅ (marchcat)[https://github.com/marchcat]
✅ (Geenz)[https://github.com/Geenz]
✅ (AtlasLinden)[https://github.com/AtlasLinden]
✅ (callumlinden)[https://github.com/callumlinden]
✅ (akleshchev)[https://github.com/akleshchev]
✅ (erikkundiman)[https://github.com/erikkundiman]
✅ (secretfoxclaw)[https://github.com/secretfoxclaw]
✅ (Ansariel)[https://github.com/Ansariel]
✅ (bennettgoble)[https://github.com/bennettgoble]
✅ (fmartian)[https://github.com/fmartian]
✅ (brad-linden)[https://github.com/brad-linden]
✅ (Nicky-D)[https://github.com/Nicky-D]
@rye
Rye seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.