Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【OSCP】implement KMPRT17 multiparty PSI #52

Merged
merged 10 commits into from
Jun 25, 2024
Merged

【OSCP】implement KMPRT17 multiparty PSI #52

merged 10 commits into from
Jun 25, 2024

Conversation

zhangwfjh
Copy link
Contributor

Fixed #12

@6fj 6fj requested a review from zhanglei486 January 23, 2024 08:19
zhanglei486
zhanglei486 previously approved these changes Jan 31, 2024
Copy link

@zhanglei486 zhanglei486 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

psi/psi/core/kmprt17_mp_psi/kmprt17_hashing.cc Outdated Show resolved Hide resolved
psi/psi/core/kmprt17_mp_psi/kmprt17_mp_psi.cc Outdated Show resolved Hide resolved
zhanglei486
zhanglei486 previously approved these changes Jan 31, 2024
Copy link

@zhanglei486 zhanglei486 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Candicepan
Copy link

@zhangwfjh Thanks for you contribution, currently this PR is under security review by our team, this PR will be merged if our security team has no more concerns.

Copy link

github-actions bot commented Mar 1, 2024

Stale pull request message. Please comment to remove stale tag. Otherwise this pr will be closed soon.

Copy link

Stale pull request message. Please comment to remove stale tag. Otherwise this pr will be closed soon.

@qxzhou1010
Copy link
Contributor

LGTM

@6fj 6fj requested a review from qxzhou1010 May 29, 2024 05:40
Copy link

github-actions bot commented May 29, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link
Contributor

@qxzhou1010 qxzhou1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qxzhou1010
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA

@6fj
Copy link
Member

6fj commented Jun 13, 2024

recheck

@6fj
Copy link
Member

6fj commented Jun 13, 2024

Hi @zhangwfjh

bazel file linter 和 编译 都失败了,麻烦检查一下。感谢!

@6fj
Copy link
Member

6fj commented Jun 24, 2024

@zhangwfjh
Copy link
Contributor Author

hi @zhangwfjh

目前在mac测试中,相关测试失败了(请先忽略seal pir test的失败)。

https://app.circleci.com/pipelines/github/secretflow/psi/381/workflows/cfc5ddf5-c145-4112-ae99-f81e69800e3d/jobs/1358?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link&utm_content=summary

image

本地无法复现,是否可以提供 docker 环境?怀疑和 p2p 相关,这里存在类似问题

@6fj 6fj merged commit 7822e93 into secretflow:main Jun 25, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

选择并在 SecretFlow 中实现多方 PSI 协议
5 participants