Skip to content
This repository has been archived by the owner on Oct 14, 2020. It is now read-only.

Commit

Permalink
Correct Nmap & Ncrack Version
Browse files Browse the repository at this point in the history
Nmap & Ncrack have their own Versioning schemes and should not use the
chart version but the appVersion.

This also corrects a typo in the ci config which build the wrong
tag name (missing the `r`).
  • Loading branch information
J12934 committed Oct 6, 2020
1 parent 6d1ee24 commit 491aaff
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ jobs:
repository: securecodebox/scanner-nmap
path: ./scanners/nmap/scanner/
# Note: not prefixed with a "v" as this seems to match nmap versioning standards
tags: "7.80,7.80-2,latest"
tags: "7.80,7.80-r2,latest"
- uses: docker/build-push-action@v1
name: "Build & Push kube-hunter Scanner Image"
with:
Expand Down
2 changes: 1 addition & 1 deletion scanners/ncrack/templates/ncrack-scan-type.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ spec:
restartPolicy: OnFailure
containers:
- name: ncrack
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.Version }}"
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
command: ["ncrack", "-oX", "/home/securecodebox/ncrack-results.xml"]
resources:
{{- toYaml .Values.scannerJob.resources | nindent 16 }}
Expand Down
2 changes: 1 addition & 1 deletion scanners/nmap/templates/nmap-scan-type.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ spec:
restartPolicy: OnFailure
containers:
- name: nmap
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.Version }}"
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
command: ["nmap", "-oX", "/home/securecodebox/nmap-results.xml"]
resources:
{{- toYaml .Values.scannerJob.resources | nindent 16 }}
Expand Down

0 comments on commit 491aaff

Please sign in to comment.