-
-
Notifications
You must be signed in to change notification settings - Fork 18
feat(conf): Extra conf files support #509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RKNF404
wants to merge
15
commits into
live
Choose a base branch
from
extra-conf-files
base: live
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+38
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyalOughtness
approved these changes
Nov 11, 2025
Contributor
|
from codacy: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a directory (
trivalent.conf.d) which can have multiple files in a similar format totrivalent.conf.With that it changes how these files and their variables are handled. To avoid declaration conflict, the system config (
trivalent.conf) usesCHROMIUM_SYSTEM_FLAGS, andCHROMIUM_FLAGSis used by the.ddirectory conf files.FEATURESwill add all comma-separated features to theenable-featuresflag viaCHROMIUM_SYSTEM_FLAGS, to avoidenable-featuresoverwriting itself when added multiple times.This also makes
trivalent.confreplaceable in the spec, since it should only be used for temporary measures.