Kent 3/liquidity orderbook #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| info: MessageInfo, | ||
| new_lb_pair_implementation: ContractInstantiationInfo, | ||
| ) -> Result<Response> { | ||
| let state = CONFIG.load(deps.storage)?; | ||
| let config = CONFIG.load(deps.storage)?; | ||
| only_owner(&info.sender, &config.owner)?; |
There was a problem hiding this comment.
actually while creating the lb-pair-implementation we have option to whether let people set implementations for this specific pair or not so no need to only_owner()
Added admin auth
kent-3
force-pushed
the
kent-3/liquidity-orderbook
branch
from
8565a68 to
c4aa9a8
Compare
it was being included in CI automatically
kent-3
added a commit
that referenced
this pull request
Nov 27, 2023
* rough start * close, lots of missing imports * fixed errors in basic_staking * Added admin_auth * added lbAdmin * fixes * Lp + Dao fees * cargo fmt * delete unused file * organize contract interfaces a bit * library improvements * misc improvements to lb_factory * misc improvements to lb_pair * small test improvements * just git merge things * use shade c_std instead of cosmwasm_std * uncomment GetPairInfo and SwapSimulation * addressing build warnings * add some cargo helpers for lb contracts * remove comparison that is always true * cleanup * delete old shadeswap_shared package * fix errors and warnings, add router interface * dependency fixes and formatting * dependency fixes and formatting * refactoring TokenType * delete old shadeswap_shared again * fixing merge mistake * cargo +nightly fmt * use swap::core for TokenAmount and TokenType * fix unused doc comments * finally fixed shade-protocol build issue * dependency mods * refactor lb_libraries * build success * remove archive_lb_router it was being included in CI automatically * fix test dependencies, run some tests in serial * try to fix CI * rand crate causes errors with wasm target --------- Co-authored-by: DrPresident <jacksonswenson@securesecrets.org> Co-authored-by: itshaseebsaeed <haseebsyed30000@gmail.com> Co-authored-by: Haseeb Saeed <34556583+itsHaseebSaeed@users.noreply.github.com>
kent-3
added a commit
that referenced
this pull request
Jan 12, 2024
* rough start * close, lots of missing imports * fixed errors in basic_staking * Added admin_auth * added lbAdmin * fixes * Lp + Dao fees * cargo fmt * delete unused file * organize contract interfaces a bit * library improvements * misc improvements to lb_factory * misc improvements to lb_pair * small test improvements * just git merge things * use shade c_std instead of cosmwasm_std * uncomment GetPairInfo and SwapSimulation * addressing build warnings * add some cargo helpers for lb contracts * remove comparison that is always true * cleanup * delete old shadeswap_shared package * fix errors and warnings, add router interface * dependency fixes and formatting * dependency fixes and formatting * refactoring TokenType * delete old shadeswap_shared again * fixing merge mistake * cargo +nightly fmt * use swap::core for TokenAmount and TokenType * fix unused doc comments * finally fixed shade-protocol build issue * dependency mods * refactor lb_libraries * build success * remove archive_lb_router it was being included in CI automatically * fix test dependencies, run some tests in serial * try to fix CI * rand crate causes errors with wasm target --------- Co-authored-by: DrPresident <jacksonswenson@securesecrets.org> Co-authored-by: itshaseebsaeed <haseebsyed30000@gmail.com> Co-authored-by: Haseeb Saeed <34556583+itsHaseebSaeed@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merging my long-running branch with this one.
Notable changes
&mut selfNext steps