Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final audits and optimizations #395

Merged

Conversation

itsHaseebSaeed
Copy link

  1. added oracles for the vol and fee metrics
  2. fixed some errors
  3. made final audits and optimizations

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 94.37610% with 128 lines in your changes are missing coverage. Please review.

Project coverage is 81.97%. Comparing base (2328cff) to head (8eddf07).
Report is 3 commits behind head on liquidity-orderbook-develop.

Files Patch % Lines
contracts/liquidity_book/lb_pair/src/query.rs 89.66% 68 Missing ⚠️
contracts/liquidity_book/lb_pair/src/execute.rs 96.37% 36 Missing ⚠️
contracts/liquidity_book/lb_pair/src/contract.rs 96.07% 4 Missing ⚠️
contracts/liquidity_book/lb_pair/src/helper.rs 96.19% 4 Missing ⚠️
packages/multi_test/src/interfaces/lb_pair.rs 95.08% 3 Missing ⚠️
.../src/contract_interfaces/liquidity_book/lb_pair.rs 25.00% 3 Missing ⚠️
...aces/liquidity_book/lb_libraries/math/safe_math.rs 96.07% 2 Missing ⚠️
...faces/liquidity_book/lb_libraries/oracle_helper.rs 95.00% 2 Missing ⚠️
contracts/liquidity_book/lb_pair/src/state.rs 0.00% 1 Missing ⚠️
...ntracts/liquidity_book/lb_staking/schema/schema.rs 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@                       Coverage Diff                       @@
##           liquidity-orderbook-develop     #395      +/-   ##
===============================================================
- Coverage                        82.05%   81.97%   -0.08%     
===============================================================
  Files                              200      204       +4     
  Lines                            30067    29674     -393     
===============================================================
- Hits                             24671    24326     -345     
+ Misses                            5396     5348      -48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itsHaseebSaeed itsHaseebSaeed merged commit 9d91e6e into liquidity-orderbook-develop Mar 19, 2024
18 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant