Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serverless considered shameful #1376

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Serverless considered shameful #1376

merged 2 commits into from
Jan 9, 2024

Conversation

72636c
Copy link
Member

@72636c 72636c commented Jan 9, 2024

Ghost-written-by: Sam Chung <samc@seek.com.au>

@72636c @samchungy
Serverless considered shameful
0280758 
Co-authored-by: Sam Chung <samc@seek.com.au>
@72636c 72636c requested review from a team as code owners January 9, 2024 01:48
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3e7c1ff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@72636c
Copy link
Member Author

72636c commented Jan 9, 2024

ugh, I'm guessing it doesn't play nicely with the local link:

skuba/scripts/test-template.sh

Lines 52 to 54 in c2b0b54

# @types/jest doesn't seem to get hoisted correctly when linking with pnpm.
echo "--- pnpm add --save-dev ../skuba ${types_jest}"
pnpm add --save-dev ../skuba "${types_jest}"

@72636c @samchungy
Tar
3e7c1ff 
Co-authored-by: Sam Chung <samc@seek.com.au>
@72636c 72636c merged commit 5722d2a into master Jan 9, 2024
18 checks passed
@72636c 72636c deleted the shame branch January 9, 2024 03:07
samchungy
samchungy reviewed Jan 9, 2024
View reviewed changes
scripts/test-template.sh
@@ -21,6 +21,9 @@ pnpm install --frozen-lockfile
echo '--- pnpm run build'
pnpm run build

echo '--- npm pack'
npm pack
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what did pnpm ever do to you

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn did something to me years ago

@72636c 72636c mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samchungy samchungy samchungy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@72636c @samchungy