-
Notifications
You must be signed in to change notification settings - Fork 17
Update Firebase SDK to v12.1.0 and dependencies #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update Firebase SDK to v12.1.0 and dependencies #32
Conversation
- Bump Firebase iOS SDK from 11.1.0 to 12.1.0 - Update analytics-swift from 1.4.7 to 1.8.0 - Update GoogleUtilities from 8.0.2 to 8.1.0 - Update related Firebase and Google dependencies to latest versions
* removed due to shutdown of service
Please consider merging this PR. Currently, Segment makes it impossible to use the current version of Firebase, creating all sorts of dependency issues with libraries that keep up-to-date on Firebase's major. A well-maintained library should always support the current stable major of its dependencies. |
If you need immediate resolution of things, feel free to reach out to your segment rep or fork the repo. No need to lecture on what a well-maintained library should be like. I have a team of 5 people, 60 libraries to maintain and 253 destinations to look after. I'm sure you can sympathize. |
Package.swift
Outdated
@@ -1,15 +1,15 @@ | |||
// swift-tools-version:5.3 | |||
// swift-tools-version:6.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see that 6.0 has made it to https://github.com/swiftlang/swift-package-manager/tree/main/Documentation/ReleaseNotes yet. Not sure why.
Presumably this is just a "bump to latest", I don't see any change that should benefit from or necessitate it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've lowered the package swift tools requirement to 5.9
to match the version defined in https://github.com/segmentio/analytics-swift.git
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was this stuff removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove deeplink setup due to https://firebase.google.com/support/dynamic-links-faq
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah thanks. Makes sense.
This will bump the minimum deployment level to match Firebase.
Remove deeplink setup due to https://firebase.google.com/support/dynamic-links-faq