Update library mockito-core to 5.3.1 and fix test (#411)

* Update library mockito-core to 5.1.0 and fix test * Update mockito-core to 5.2.0 * Update mockito-core to 5.3.0 * Add .factorypath in .gitignore, update mockito-core to 5.3.1
segmentio · May 10, 2023 · 923e6cc · 923e6cc
1 parent 4cbf144
commit 923e6cc
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 19 deletions.
diff --git a/.gitignore b/.gitignore
@@ -128,3 +128,4 @@ atlassian-ide-plugin.xml
 .classpath
 .project
 .settings/
+.factorypath
diff --git a/analytics/src/test/java/com/segment/analytics/TypedInterceptorTest.java b/analytics/src/test/java/com/segment/analytics/TypedInterceptorTest.java
@@ -1,7 +1,7 @@
 package com.segment.analytics;
 
+import static org.junit.Assert.assertNull;
 import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.verify;
 
 import com.segment.analytics.messages.AliasMessage;
 import com.segment.analytics.messages.GroupMessage;
@@ -18,26 +18,26 @@ public void messagesFanOutCorrectly() {
 
     AliasMessage alias = AliasMessage.builder("foo").userId("bar").build();
     interceptor.intercept(alias);
-    verify(interceptor).alias(alias);
+    assertNull(interceptor.alias(alias));
 
     GroupMessage group = GroupMessage.builder("foo").userId("bar").build();
     interceptor.intercept(group);
-    verify(interceptor).group(group);
+    assertNull(interceptor.group(group));
 
     IdentifyMessage identify = IdentifyMessage.builder().userId("bar").build();
     interceptor.intercept(identify);
-    verify(interceptor).identify(identify);
+    assertNull(interceptor.identify(identify));
 
     ScreenMessage screen = ScreenMessage.builder("foo").userId("bar").build();
     interceptor.intercept(screen);
-    verify(interceptor).screen(screen);
+    assertNull(interceptor.screen(screen));
 
     PageMessage page = PageMessage.builder("foo").userId("bar").build();
     interceptor.intercept(page);
-    verify(interceptor).page(page);
+    assertNull(interceptor.page(page));
 
     TrackMessage track = TrackMessage.builder("foo").userId("bar").build();
     interceptor.intercept(track);
-    verify(interceptor).track(track);
+    assertNull(interceptor.track(track));
   }
 }
diff --git a/analytics/src/test/java/com/segment/analytics/TypedTransformerTest.java b/analytics/src/test/java/com/segment/analytics/TypedTransformerTest.java
@@ -1,7 +1,7 @@
 package com.segment.analytics;
 
+import static org.junit.Assert.assertFalse;
 import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.verify;
 
 import com.segment.analytics.messages.AliasMessage;
 import com.segment.analytics.messages.GroupMessage;
@@ -18,26 +18,26 @@ public void messagesFanOutCorrectly() {
 
     AliasMessage.Builder alias = AliasMessage.builder("foo").userId("bar");
     transformer.transform(alias);
-    verify(transformer).alias(alias);
+    assertFalse(transformer.alias(alias));
 
     GroupMessage.Builder group = GroupMessage.builder("foo").userId("bar");
     transformer.transform(group);
-    verify(transformer).group(group);
+    assertFalse(transformer.group(group));
 
     IdentifyMessage.Builder identify = IdentifyMessage.builder().userId("bar");
     transformer.transform(identify);
-    verify(transformer).identify(identify);
+    assertFalse(transformer.identify(identify));
 
     ScreenMessage.Builder screen = ScreenMessage.builder("foo").userId("bar");
     transformer.transform(screen);
-    verify(transformer).screen(screen);
+    assertFalse(transformer.screen(screen));
 
     PageMessage.Builder page = PageMessage.builder("foo").userId("bar");
     transformer.transform(page);
-    verify(transformer).page(page);
+    assertFalse(transformer.page(page));
 
     TrackMessage.Builder track = TrackMessage.builder("foo").userId("bar");
     transformer.transform(track);
-    verify(transformer).track(track);
+    assertFalse(transformer.track(track));
   }
 }
diff --git a/pom.xml b/pom.xml
@@ -31,7 +31,7 @@
     <kotlin.version>1.7.20</kotlin.version>
     <spotless.version>2.27.2</spotless.version>
     <retrofit.version>2.9.0</retrofit.version>
-    <auto.version>1.10</auto.version>
+    <auto.version>1.10.1</auto.version>
 
     <findbugs.version>3.0.1</findbugs.version>
     <gson.version>2.9.1</gson.version>
@@ -45,7 +45,7 @@
     <!-- Test Dependencies -->
     <junit.version>4.13.2</junit.version>
     <burst.version>1.2.0</burst.version>
-    <mockito.version>4.9.0</mockito.version>
+    <mockito.version>5.3.1</mockito.version>
     <assertj.version>3.24.2</assertj.version>
   </properties>
 
@@ -189,7 +189,7 @@
                 <version>1.5</version>
                 <style>GOOGLE</style>
               </googleJavaFormat>
-              <removeUnusedImports />
+              <removeUnusedImports/>
             </java>
           </configuration>
         </plugin>
@@ -229,7 +229,7 @@
                     </goals>
                   </pluginExecutionFilter>
                   <action>
-                    <ignore />
+                    <ignore/>
                   </action>
                 </pluginExecution>
               </pluginExecutions>
@@ -276,7 +276,7 @@
             <format>html</format>
             <format>xml</format>
           </formats>
-          <check />
+          <check/>
         </configuration>
       </plugin>
       <plugin>