Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow screen events to have source middleware applied #1213

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

silesky
Copy link
Contributor

@silesky silesky commented Jan 13, 2025

addresses #1211

Copy link

changeset-bot bot commented Jan 13, 2025

🦋 Changeset detected

Latest commit: 64ad0f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@segment/analytics-next Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@silesky silesky changed the title allow screen events to have source middleware Allow screen events to have source middleware Jan 13, 2025
@silesky silesky changed the title Allow screen events to have source middleware Allow screen events to have source middleware applied Jan 13, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.92%. Comparing base (7f9d5a0) to head (64ad0f5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1213   +/-   ##
=======================================
  Coverage   82.92%   82.92%           
=======================================
  Files         216      216           
  Lines        5785     5785           
  Branches     1308     1308           
=======================================
  Hits         4797     4797           
  Misses        988      988           
Flag Coverage Δ
browser 92.23% <ø> (ø)
core 89.86% <ø> (ø)
node 87.93% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@silesky silesky merged commit 9d1b042 into master Jan 13, 2025
8 checks passed
@silesky silesky deleted the support-add-source-middleware-screen-events branch January 13, 2025 22:54
@github-actions github-actions bot mentioned this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants