add note about secrets manager#504
Merged
bhavanki merged 3 commits intosegmentio:masterfrom Jun 17, 2024
Merged
Conversation
add secretsmanager notes
bhavanki
reviewed
Jun 10, 2024
Contributor
bhavanki
left a comment
bhavanki
left a comment
There was a problem hiding this comment.
Thanks for addressing this documentation gap!
I'm assuming that @danmactough is still maintaining this backend, and that it is not experimental like the S3 backends. My assumptions could be wrong, but I feel optimistic today 😁
Contributor
Author
|
@bhavanki done |
danmactough
approved these changes
Jun 10, 2024
Contributor
danmactough
left a comment
danmactough
left a comment
There was a problem hiding this comment.
Thanks for addressing this documentation gap!
I'm assuming that @danmactough is still maintaining this backend, and that it is not experimental like the S3 backends. My assumptions could be wrong, but I feel optimistic today 😁
"maintaining" is a bit strong as these rare PRs about the secrets manager integration are the limit of my involvement 😄
bhavanki
approved these changes
Jun 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#267 added secret manager support, so I updated the readme to note that. That way people won't need to dig through the issues to figure out what the support status is.
I've checked "allow edits by maintainers", so feel free to change the wording / formatting :)