Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Add store configuration support for SSM store #532

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

bhavanki
Copy link
Contributor

@bhavanki bhavanki commented Jul 3, 2024

The new Config and SetConfig methods on the Store interface allow
implementations to maintain their own configurations. Only the SSM store
fully implements the methods; the others return an empty configuration
and do not support setting one.

The store configuration itself holds a list of required tags for each
written secret. Enforcement of the tags is not yet implemented. Although
the configuration struct is exported from its package, it is not part of
chamber's client interface and is subject to change at any time.

The SSM store implementation stores its configuration as a secret
inside the newly reserved "_chamber" service as a JSON document. The
schema is not exported, so users shouldn't build anything from it.

The new Config and SetConfig methods on the Store interface allow
implementations to maintain their own configurations. Only the SSM store
fully implements the methods; the others return an empty configuration
and do not support setting one.

The store configuration itself holds a list of required tags for each
written secret. Enforcement of the tags is not yet implemented. Although
the configuration struct is exported from its package, it is not part of
chamber's client interface and is subject to change at any time.

The SSM store implementation stores its configuration as a secret
inside the newly reserved "_chamber" service as a JSON document. The
schema is not exported, so users shouldn't build anything from it.
@bhavanki bhavanki requested a review from a team as a code owner July 3, 2024 19:58
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 43.58974% with 22 lines in your changes missing coverage. Please review.

Project coverage is 36.27%. Comparing base (401c3ae) to head (a98febd).
Report is 4 commits behind head on master.

Files Patch % Lines
store/ssmstore.go 61.90% 4 Missing and 4 partials ⚠️
store/nullstore.go 0.00% 6 Missing ⚠️
store/s3store.go 0.00% 6 Missing ⚠️
store/secretsmanagerstore.go 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #532      +/-   ##
==========================================
+ Coverage   36.16%   36.27%   +0.11%     
==========================================
  Files          29       29              
  Lines        2552     2591      +39     
==========================================
+ Hits          923      940      +17     
- Misses       1550     1568      +18     
- Partials       79       83       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sindhusegment sindhusegment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for explaining this in stand up!

@bhavanki bhavanki merged commit dd1ae9a into master Aug 1, 2024
15 checks passed
@bhavanki bhavanki deleted the store-config branch August 1, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants