Skip to content

Conversation

joe-ayoub-segment
Copy link
Contributor

Proposed changes

Docs for new Destination:
Amazon EventBridge (Actions)
ID: 67be4b2aef865ee6e0484fe5

There is a Classic Destinations already. Should the docs reference each other somehow?

Merge timing

This Destination is in Private Beta - but soon to be Public Beta.

Related issues (optional)

https://twilio-engineering.atlassian.net/browse/STRATCONN-6121

Copy link
Contributor

@longstoryshort longstoryshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have 2 suggestions:
Suggestion 1 - expand Getting Started # 7:
7. Before saving your mapping, click the Create Partner Source button. This step creates a new EventBridge Partner Event Source in your AWS account if it does not exist yet. The source name is
aws.partner/segment.com/SEGMENT_SOURCE_ID. This step is required. Without it, data will not flow to EventBridge.

Suggestion 2 - add a note about connecting the source to event bus in AWS:
Once EventBridge Partner Event Source is created in your AWS account, you can associate the source with EventBridge Event Bus.

@stayseesong
Copy link
Contributor

@joe-ayoub-segment the actions destination doesn't need to reference the class docs. Also, do you want this merged once the destination goes to Public beta, or would you like for it to be merged while in private beta?

@stayseesong stayseesong added the new-integration Added a new source or destination label Sep 24, 2025
@joe-ayoub-segment
Copy link
Contributor Author

Hi @stayseesong
We'll probably want to go to public beta next week.
For now the doc should be hidden.

stayseesong
stayseesong previously approved these changes Sep 25, 2025
@stayseesong stayseesong requested review from longstoryshort and removed request for longstoryshort September 25, 2025 17:45
@joe-ayoub-segment
Copy link
Contributor Author

Hi @stayseesong just wondering why this didn't merge after you approved it? Does someone else from docs also need to review?

@stayseesong
Copy link
Contributor

@joe-ayoub-segment I can't merge this in because you requested @longstoryshort as a required reviewer, so until @longstoryshort reviews this, I can't merge this in

@joe-ayoub-segment joe-ayoub-segment removed the request for review from longstoryshort September 30, 2025 08:11
@joe-ayoub-segment
Copy link
Contributor Author

Hi @stayseesong I removed @longstoryshort as a requested reviewer. Can we merge now please?

@joe-ayoub-segment
Copy link
Contributor Author

Hi @stayseesong can we deploy please? This Destination is moving to Public Beta now.

auto-merge was automatically disabled September 30, 2025 13:01

Head branch was modified

Copy link
Contributor

@sade-wusi sade-wusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few page edits but good to go!

@sade-wusi sade-wusi merged commit 3ed461e into develop Sep 30, 2025
4 checks passed
@sade-wusi sade-wusi deleted the eventbridge-actions branch September 30, 2025 14:31
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-integration Added a new source or destination
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants