-
Notifications
You must be signed in to change notification settings - Fork 392
[EventBridge Actions] - new Destination #7966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have 2 suggestions:
Suggestion 1 - expand Getting Started # 7:
7. Before saving your mapping, click the Create Partner Source button. This step creates a new EventBridge Partner Event Source in your AWS account if it does not exist yet. The source name is
aws.partner/segment.com/SEGMENT_SOURCE_ID
. This step is required. Without it, data will not flow to EventBridge.
Suggestion 2 - add a note about connecting the source to event bus in AWS:
Once EventBridge Partner Event Source is created in your AWS account, you can associate the source with EventBridge Event Bus.
@joe-ayoub-segment the actions destination doesn't need to reference the class docs. Also, do you want this merged once the destination goes to Public beta, or would you like for it to be merged while in private beta? |
Hi @stayseesong |
Hi @stayseesong just wondering why this didn't merge after you approved it? Does someone else from docs also need to review? |
@joe-ayoub-segment I can't merge this in because you requested @longstoryshort as a required reviewer, so until @longstoryshort reviews this, I can't merge this in |
Hi @stayseesong I removed @longstoryshort as a requested reviewer. Can we merge now please? |
Hi @stayseesong can we deploy please? This Destination is moving to Public Beta now. |
Head branch was modified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few page edits but good to go!
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Proposed changes
Docs for new Destination:
Amazon EventBridge (Actions)
ID: 67be4b2aef865ee6e0484fe5
There is a Classic Destinations already. Should the docs reference each other somehow?
Merge timing
This Destination is in Private Beta - but soon to be Public Beta.
Related issues (optional)
https://twilio-engineering.atlassian.net/browse/STRATCONN-6121