Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove serialize/deserialize for accesslist #1701

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

codchen
Copy link
Collaborator

@codchen codchen commented May 26, 2024

Describe your changes and provide context

Because accessLists are only used within the lifespan of its transaction, there is no need to serialize/deserialize it as it won't be transmitted over wire nor written to disk. This would improve performance for transactions that make heavy usage of accesslists

Testing performed to validate your change

no behavioral change so existing unit tests should cover

Copy link

codecov bot commented May 26, 2024

Codecov Report

Attention: Patch coverage is 60.52632% with 15 lines in your changes missing coverage. Please review.

Project coverage is 60.78%. Comparing base (a0e7266) to head (26c91e6).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1701      +/-   ##
==========================================
- Coverage   60.87%   60.78%   -0.10%     
==========================================
  Files         370      370              
  Lines       27436    27447      +11     
==========================================
- Hits        16702    16683      -19     
- Misses       9592     9622      +30     
  Partials     1142     1142              
Files Coverage Δ
x/evm/keeper/msg_server.go 76.53% <100.00%> (+0.08%) ⬆️
x/evm/state/statedb.go 47.22% <16.66%> (-1.80%) ⬇️
x/evm/state/accesslist.go 86.84% <67.74%> (-7.61%) ⬇️

... and 2 files with indirect coverage changes

x/evm/state/accesslist.go Fixed Show fixed Hide fixed
x/evm/state/accesslist.go Fixed Show fixed Hide fixed
@codchen codchen force-pushed the optimize-accesslist branch 2 times, most recently from 3d77fa8 to 7a64d32 Compare May 27, 2024 11:40
@codchen codchen force-pushed the optimize-accesslist branch 2 times, most recently from f7a6231 to 9fdea2b Compare June 10, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants