-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pointers contracts: support for ERC1155 and CW1155 contracts #1755
Open
dvli2007
wants to merge
90
commits into
sei-protocol:main
Choose a base branch
from
palletexchange:pointers/erc1155-cw1155
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Pointers contracts: support for ERC1155 and CW1155 contracts #1755
dvli2007
wants to merge
90
commits into
sei-protocol:main
from
palletexchange:pointers/erc1155-cw1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This pull request is a collaboration by Orbiters/Frensei and Pallet Exchange to bring full support for 1155 contract standards to Sei. We added:
The ERC1155 contract is a well known and battle tested contract standard for NFTs and for semi-fungible tokens, allowing efficient creation and handling of very large quantities of tokens. Supporting the 1155 standard on-chain opens up the possibility for gaming (games with onchain assets almost always need to use a 1155 contract), open edition mints, and much more. The Orbiters/Frensei and Pallet Exchange teams see full support for 1155-type contracts/assets on Sei as mission critical to having a feature-complete general-purpose blockchain.
To further note, we have pioneered the first CW1155 standard that we know of. Cosmwasm ecosystem has historically lacked any such standard, with a few known attempts in the past that never received traction. Given Sei is EVM compatible and the ecosystem's momentum, we believe Sei will be the first Cosmwasm chain with a well-adopted CW1155 standard.
Testing performed to validate your change
/contracts/test/CW1155ERC1155PointerTest.t.sol
)/contracts/test/ERC1155toCW1155PointerTest.js
)/contracts/test/CW1155toERC1155PointerTest.js
)/precompiles/pointerview/pointerview_test.go
)/x/evm/client/wasm/query_test.go
)/x/evm/integration_test.go
)/x/evm/keeper/grpc_query_test.go
)/x/evm/keeper/msg_server_test.go
)/x/evm/keeper/pointer_test.go
)seid q evm erc1155-payload
,seid tx evm register-cw-pointer
,seid tx evm register-evm-pointer