Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop flushing deferred info into receipt store #1909

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Conversation

codchen
Copy link
Collaborator

@codchen codchen commented Oct 29, 2024

Describe your changes and provide context

Iterating through the whole transient store would fetch things (e.g. deferred info) other than receipt and flush them into the receipt store. This would not cause issue correctness wise but would make receipt store grow faster in size and increase time to flush receipts.

Testing performed to validate your change

unit test

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.36%. Comparing base (6a3c5f3) to head (1cf0563).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1909      +/-   ##
==========================================
- Coverage   61.36%   61.36%   -0.01%     
==========================================
  Files         263      263              
  Lines       23308    23308              
==========================================
- Hits        14303    14302       -1     
- Misses       8001     8002       +1     
  Partials     1004     1004              
Files with missing lines Coverage Δ
x/evm/keeper/receipt.go 70.37% <100.00%> (+2.77%) ⬆️

... and 1 file with indirect coverage changes

@philipsu522 philipsu522 merged commit 97346a2 into main Oct 30, 2024
49 checks passed
@philipsu522 philipsu522 deleted the fix-receipt-flushing branch October 30, 2024 17:16
philipsu522 added a commit that referenced this pull request Oct 30, 2024
Co-authored-by: Philip Su <philip.su.522@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants