Skip to content

Commit

Permalink
Fix
Browse files Browse the repository at this point in the history
  • Loading branch information
yzang2019 committed Sep 11, 2024
1 parent 24c4fa4 commit 35e0e8e
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 8 deletions.
9 changes: 1 addition & 8 deletions mutable_tree.go
Original file line number Diff line number Diff line change
Expand Up @@ -556,8 +556,6 @@ func (tree *MutableTree) LazyLoadVersion(targetVersion int64) (toReturn int64, t
}
}()

tree.versions[targetVersion] = true

iTree := &ImmutableTree{
ndb: tree.ndb,
version: targetVersion,
Expand Down Expand Up @@ -940,7 +938,7 @@ func (tree *MutableTree) SaveVersion() ([]byte, int64, error) {
// Mtx is already held at this point
clone := tree.ITree.clone()
clone.version = version
tree.versions[version] = true
tree.ndb.resetLatestVersion(version)

// set new working tree
tree.ITree = clone
Expand Down Expand Up @@ -1170,10 +1168,6 @@ func (tree *MutableTree) DeleteVersionsRange(fromVersion, toVersion int64) error
return err
}

for version := fromVersion; version < toVersion; version++ {
delete(tree.versions, version)
}

return nil
}

Expand All @@ -1193,7 +1187,6 @@ func (tree *MutableTree) DeleteVersion(version int64) error {
return err
}

delete(tree.versions, version)
return nil
}

Expand Down
13 changes: 13 additions & 0 deletions nodedb.go
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,10 @@ func (ndb *nodeDB) DeleteVersionsRange(fromVersion, toVersion int64) error {
if err != nil {
return err
}
first, err := ndb.getFirstVersion()
if err != nil {
return err
}
if latest < toVersion {
return errors.Errorf("cannot delete latest saved version (%d)", latest)
}
Expand Down Expand Up @@ -580,6 +584,15 @@ func (ndb *nodeDB) DeleteVersionsRange(fromVersion, toVersion int64) error {
return nil
})

if first <= toVersion && first >= fromVersion {
// Reset first version if we are deleting all versions from first -> toVersion
ndb.resetFirstVersion(toVersion + 1)
}
if latest <= toVersion {
// Reset latest version if we are deleting all versions from fromVersion -> latest
ndb.resetLatestVersion(fromVersion + 1)
}

if err != nil {
return err
}
Expand Down

0 comments on commit 35e0e8e

Please sign in to comment.