Updated KniDeviceList to use internal::DeviceListBase.
#1797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1797 +/- ##
==========================================
- Coverage 83.07% 83.07% -0.01%
==========================================
Files 284 284
Lines 48967 48966 -1
Branches 10550 10389 -161
==========================================
- Hits 40681 40679 -2
+ Misses 7181 7180 -1
- Partials 1105 1107 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
seladb
reviewed
May 1, 2025
Comment on lines
+220
to
+225
| /// @brief Get the current capacity of the vector. | ||
| /// @return The number of elements that can be held in the vector without requiring a reallocation. | ||
| size_t capacity() const | ||
| { | ||
| return m_Vector.capacity(); | ||
| } |
There was a problem hiding this comment.
Not at the moment, but since a reserve is provided, it seems nice to also provide a way to actually check the capacity of the vector, no? Most of the containers I have seen either have both or neither.
There was a problem hiding this comment.
I guess it's ok and we can keep it...
seladb
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
reserveandcapacitytoPointerVectorKniDeviceListto useinternal::DeviceListBase.