#585 reply for assigned Pull Request

self-xdsd · Oct 10, 2020 · c329b7c · c329b7c
1 parent 1667395
commit c329b7c
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 4 deletions.
diff --git a/self-core-impl/src/main/java/com/selfxdsd/core/managers/StoredProjectManager.java b/self-core-impl/src/main/java/com/selfxdsd/core/managers/StoredProjectManager.java
@@ -349,14 +349,23 @@ private void assignTask(final Project project,
             LOG.debug("Elected @" + contributor.username() + ".");
             final Task assigned = task.assign(contributor);
             issue.assign(contributor.username());
-            issue.comments().post(
-                String.format(
+            final String reply;
+            if(issue.isPullRequest()) {
+                reply = String.format(
+                    project.language().reply("pullRequestAssigned.comment"),
+                    contributor.username(),
+                    assigned.deadline(),
+                    assigned.estimation()
+                );
+            } else {
+                reply = String.format(
                     project.language().reply("taskAssigned.comment"),
                     contributor.username(),
                     assigned.deadline(),
                     assigned.estimation()
-                )
-            );
+                );
+            }
+            issue.comments().post(reply);
             LOG.debug(
                 "Task #" + issue.issueId() + " assigned to @"
                     + contributor.username() + "."

diff --git a/self-core-impl/src/test/resources/responses_en.properties b/self-core-impl/src/test/resources/responses_en.properties
@@ -17,6 +17,13 @@ taskAssigned.comment=@%s this is your task now, please go ahead. Deadline (when
                      Remember, you don't have to solve everything in this ticket - you can solve it partially\
                      and leave ``todo`` markers in the code, which will become future tasks.\n\n\
                      If you have any questions don't ask me, I'm not a technical person. Open new tickets instead.
+pullRequestAssigned.comment=@%s please review this Pull Request. Deadline (when it should be merged or closed) \
+                            is ``%s``.\n\n\
+                            You should check if the requirements have been implemented (partially or in full), \
+                            if there are unit tests covering the changes and if the CI build passes. \
+                            Feel free to reject the PR or ask for changes if it's too big or not clear enough.\n\n\
+                            Estimation here is ``%s minutes``, that's how much you will be paid. You will be \
+                            paid even if this PR gets rejected.
 resigned.comment=@%s ok, I'll find someone else to take care of it.
 cannotResign.comment=@%s this task is not assigned to you at the moment.\
                      Only the task's assignee can ask for resignation.