[out-cs-bim112] Save time with application load state LS_LOADED#92
Open
Darthyson wants to merge 1 commit intoselfbus:mainfrom
Open
[out-cs-bim112] Save time with application load state LS_LOADED#92Darthyson wants to merge 1 commit intoselfbus:mainfrom
LS_LOADED#92Darthyson wants to merge 1 commit intoselfbus:mainfrom
Conversation
During application programming, the ETS checks the current load state of the application. If this is not `LS_LOADED`, the complete firmware (0x4B20-0x75ED) ~10 kB is transferred. This firmware is neither used nor stored by our application, so we simply do not need it. This change saves us ~2 minutes and 17 seconds of programming time during the first ETS application programming.
Member
|
Does this only affect out-cs-bim112, or do other apps have the same issue? |
Member
Author
|
Theoretically, any app with a mask version >= 0x0701 that defines a memory segment for its firmware in its .knxprod could benefit from this change. In our case, this is only the out-cs-bim112. Since this behavior is not spec. compliant, I wanted to get some "field experience" with the out-cs-bim112 as a first step.
|
There was a problem hiding this comment.
Pull request overview
This PR optimizes the ETS (Engineering Tool Software) programming process by setting the application load state to LS_LOADED, preventing unnecessary firmware downloads during the first application programming.
Key Changes:
- Added
setApplicationLoadState()function to manage the application load state in EEPROM - Set load state to
LS_LOADEDat the end ofsetup()and during callback notifications - Saves approximately 2 minutes and 17 seconds of programming time by avoiding ~10 kB firmware transfer
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During application programming, the ETS checks the current load state of the application. If this is not
LS_LOADED, the complete firmware (0x4B20-0x75ED) ~10 kB is transferred. This firmware is neither used nor stored by our application, so we simply do not need it. This change saves us ~2 minutes and 17 seconds of programming time during the first ETS application programming.