fix: assuming issue 486 is Zpub instead of xpub #492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested this on an on-chain, 2 of 3 wallet, with 2 Zpus and a one xpub as cosigners. |
odudex
reviewed
Dec 10, 2024
| @@ -294,6 +298,7 @@ def parse_wallet(wallet_data, allow_assumption=None): | |||
| ) | |||
| return descriptor, label | |||
| except: | |||
| raise | |||
There was a problem hiding this comment.
On my tests I removed this duplicated raise
|
To fix pylint issue, we could put code below inside a dedicated function: |
|
We can close this one, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Assuming that issue #486 is about cosigners expressed as "Zpub" instead of "xpub", this may be a fix.
Note: Need to verify that this will not cause problems when signing a BW PSBT w/ wallet descriptor loaded.
What is the purpose of this pull request?