Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support API Key and ID #488

Merged
merged 4 commits into from
May 1, 2024
Merged

Add support API Key and ID #488

merged 4 commits into from
May 1, 2024

Conversation

mrlt8
Copy link
Contributor

@mrlt8 mrlt8 commented May 1, 2024

This adds support for the API ID and Key which are now required: mrlt8/docker-wyze-bridge#1163

Information on how to obtain the ID and Key: https://support.wyze.com/hc/en-us/articles/16129834216731-Creating-an-API-Key

@nwithan8
Copy link
Member

nwithan8 commented May 1, 2024

Please address the linting errors. Looks like an erroneous / on the DonateLink element

@nwithan8
Copy link
Member

nwithan8 commented May 1, 2024

Also, consider adding a Requires section pointing people to the GitHub for configuration details, including how to retrieve an API key

@mrlt8
Copy link
Contributor Author

mrlt8 commented May 1, 2024

Thanks for the feedback, @nwithan8! I've addressed the linting error and added a Requires section. Please let me know if there's anything else I can do!

@nwithan8 nwithan8 requested a review from Roxedus May 1, 2024 16:32
@Roxedus Roxedus merged commit 6b14944 into selfhosters:master May 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants