Disable NoRecursion for consumers
#6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any dependency can introduce complexity when solving bounds. This gets `NeRecursion` out of the way automatically. 1. it introduces a new flag, `verify-no-recursion` that controls the use of `NoRecursion` and defaults to `True`; 2. if the solver can’t find a solution with the flag enabled, it will automatically try again with the flag disabled (that is, no dependency on `no-recursion`); 3. the local `cabal.project` file has `flags: +verify-no-recursion`, which prevents the solver from trying without the flag enabled, ensuring that local package development always has `NoRecursion` enabled, even if it causes the solver to fail. This also makes a few other minor changes: - Setup no longer uses `NoRecursion`, because it’s not possible to conditionalize it with the flag. - The `noisy-deprecations` flag now has `manual: True`, because disabling it won’t help the solver. - `custom-setup` has been moved above the `flag` sections because flags can’t apply to `custom-setup`.
It’s still enabled in cabal.project for local development, but this means consumers will never have to worry about it in their dependency graph.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NoRecursion is basically a linter, so don’t have consumers build with it by default. This reduces the dependency graph.