-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue1124-migrationREADME #1129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to test bundle changes.
bundle.yaml
Outdated
target: "{output}/documentation/models/" | ||
includes: | ||
- "*.md" | ||
- action: "move" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this tested, @philblackwood ? If the sources include *.html
, and the rename is from *.md
->*.html
, I don't think you will get the desired result.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sa-bpelakh This is work that Colton and I did. What case are you imagining won't work? We tested it on the existing repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I misread replace
as rename
and got confused. My apologies.
docs/ReleaseNotes.md
Outdated
- `gist:hasUniqueSuperCategory` is replaced by `gist:hasUniqueBroader`. | ||
- Replaced the following predicates with their semantic inverses. Issue [#1070](https://github.com/semanticarts/gist/issues/1070). | ||
|
||
| gist 12 | gist 13 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you test the build, please verify that the table is formatted properly. That HTML conversion can be iffy at times.
docs/models/UnitOfMeasureModel.md
Outdated
@@ -0,0 +1,131 @@ | |||
# New Magnitudes and Units of Measure in gist 13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this awesome documentation going to replace the PowerPoint document in the migration/13.0.0
folder? We would like to avoid large binary files that prevent change tracking in our git repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@philblackwood We can put the powerpoint in gist-doc.
@philblackwood Also, the target of this merge should be the release branch, not develop, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@philblackwood This PR should be made against the release branch, not develop. You can change it by clicking Edit at the top to the right of the title and changing the base branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor wording tweaks.
@philblackwood I added a sub-PR to update your branch with some minor README and build changes in #1131 |
Co-authored-by: Rebecca Younes <rebecca.younes@semanticarts.com>
Co-authored-by: Rebecca Younes <rebecca.younes@semanticarts.com>
Performed extensive cross-checks of yaml files vs. previous release and queries they use for typos. As far as I know, this PR is completed and ready to merge (if no dependency on #1131). |
@philblackwood If you have addressed earlier comments from @sa-bpelakh and me, you need to re-request our review in order to get approvals. (The circular arrows icon next to our names on upper right.) |
Fix minor nits in migration README
Add README and associated files for gist 13 data conversion. Closes #1124.