-
Notifications
You must be signed in to change notification settings - Fork 74
fix(front): replace link in ssh debug dropdown #399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
tbogosavljevic
wants to merge
87
commits into
main
Choose a base branch
from
fix/398/ssh-docs-link
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Fixes #398 |
skipi
approved these changes
Jun 17, 2025
hamir-suspect
approved these changes
Jun 17, 2025
Collaborator
|
@tbogosavljevic you should set up signed commits and rebase the branch |
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com> Co-authored-by: Lucas Pinheiro <lpinheiro@semaphore.io>
β¦403) ## π Description We do not need log based metrics so the log level of "started" and "finished" logs in the api is reduced to debug. Also adds context metadata for grpc error logs ## β Checklist - [x] I have tested this change - [ ] ~This change requires documentation update~
## π Description Sometimes we do not want to scan licenses so this enables us to set what scanners trivy is using ## β Checklist - [x] I have tested this change - [ ] ~This change requires documentation update~
## π Description Add info note about Okta integration to the Cloud and EE versions Fixes: #383 ## β Checklist - [X] I have tested this change - [ ] This change requires documentation update
## π Description Removed the `page_size` query parameter due to inconsistent behavior. Pagination now relies on the default `page_size` and the `page` parameter only. Retained only the `x-page` and `x-has-more` response headers, which are sufficient for paginated iteration. Related [task](renderedtext/tasks#7953). ## β Checklist - [x] I have tested this change - [x] ~This change requires documentation update~ - N/A
## π Description In order to support saml login links without making changes to the database, this is required renderedtext/tasks#8141 ## β Checklist - [x] I have tested this change - [ ] This change requires documentation update
## π Description Added auditing for stop job operation via Web and API/CLI. Introduced audit middleware to the `public-api-gateway` service to capture and log these actions. The middleware is designed to be extensible for future auditing of other API operations. Related [task](renderedtext/tasks#8123). ## β Checklist - [x] I have tested this change - [x] ~This change requires documentation update~ - N/A
## π Description Use json logging formatter when running in production env Lower the priority of some hot path logs and introduce metrics in their place ## β Checklist - [x] I have tested this change - [ ] This change requires documentation update
β¦410) ## π Description `jason` was not packaged into the release so json logger is crashing in prod env and printing just a log message ## β Checklist - [x] I have tested this change - [ ] This change requires documentation update
## π Description Refresh protobuf definitions ## β Checklist - [x] I have tested this change - [ ] This change requires documentation update
β¦type (#413) ## π Description If the webhook received from the git provider is of an unsupported type (e.g. merge requests on GitLab), we should not retry processing since that is not a transient issue. ## β Checklist - [x] I have tested this change - [x] ~This change requires documentation update~ -N/A Co-authored-by: Amir Hasanbasic <43892661+hamir-suspect@users.noreply.github.com>
## π Description Related task: #29 ## β Checklist - [x] I have tested this change - [ ] This change requires documentation update
β¦323) Changes the Run workflow API implementation to allow passing parameters and improve performance. Previously, the request was synchronously waiting for repo-proxy to create a hook by retrieving data from the git provider and then schedule the workflow on the plumber. This had performance issues, and it did not support passing parameters to be used in the pipeline. The new implementation goes directly to the plumber, which only saves the request in the database before responding, and all hook processing is done asynchronously. This should improve performance, and also the plumber supports passing parameters out-of-the-box.
## π Description renderedtext/tasks#8169 ## β Checklist - [x] I have tested this change - [ ] This change requires documentation update
## π Description Add feature flag to control if we want to display rebuild pipeline button in the UI ## β Checklist - [x] I have tested this change - [ ] This change requires documentation update
In the recent changes to how the Run workflow API works in the backend, we changed by mistake the expected name for the parameter that holds the name of the pipeline file. This PR fixes that issue and adds a test to verify that the request is properly formed based on the input parameters.
This PR enables passing a list of scanners to be used for policy checks.
## π Description This version of Sonic properly passes the `io.Reader` errors to the decoder. ## β Checklist - [x] I have tested this change - [ ] This change requires documentation update
## π Description While I was working on [this task](renderedtext/tasks#8114 (comment)), I encountered an error with the update script, when users GH API token is no longer valid. This fixes it. Also, the script is duplicated over 2 services, which is not needed ## β Checklist - [x] I have tested this change - [ ] This change requires documentation update
## π Description N/A ## β Checklist - [x] I have tested this change - [x] ~This change requires documentation update~
β¦#479) ## π Description There is an issue with processing branch deletion webhooks from bitbuckets and gitlab because `branch_hub` `ArchiveResponse` does not set ok status in the response, (this expectation is set [here](https://github.com/semaphoreio/semaphore/blob/main/hooks_processor/lib/hooks_processor/clients/branch_client.ex#L165)), This PR resolves the response and also implements archive action. ## β Checklist - [ ] I have tested this change - [ ] This change requires documentation update
## π Description renderedtext/project-tasks#2647 ## β Checklist - [x] I have tested this change - [ ] This change requires documentation update: To be done
β¦481) ## π Description Branch and tag names containing forward slashes (e.g., "feature/branch-name", "release/v1.0.0") were causing 404 errors when making API requests to GitLab. Added URI.encode with char_unreserved predicate to properly encode special characters in names according to RFC 3986. ## β Checklist - [x] I have tested this change - [x] ~This change requires documentation update~
β¦ectly (#483) ## π Description renderedtext/tasks#8347 ## β Checklist - [x] I have tested this change - [x] ~This change requires documentation update~
## π Description renderedtext/project-tasks#2647 ## β Checklist - [x] I have tested this change - [ ] This change requires documentation update
## π Description Adds file size to artifacts UI ## β Checklist - [ ] I have tested this change - [ ] This change requires documentation update
) ## π Description renderedtext/project-tasks#2659 ## β Checklist - [x] I have tested this change - [ ] This change requires documentation update
## π Description renderedtext/project-tasks#2647 ## β Checklist - [x] ~I have tested this change~ - [x] This change requires documentation update
## π Description Upgrade of rails version ## β Checklist - [ ] I have tested this change - [ ] This change requires documentation update
## π Description renderedtext/project-tasks#2659 ## β Checklist - [x] I have tested this change - [ ] This change requires documentation update
β¦ation (#508) ## π Description Small UI improvement, adding a note to the notification form renderedtext/project-tasks#2659 ## β Checklist - [x] I have tested this change - [ ] This change requires documentation update
## π Description Documentation change. Add e installation instructions for v1.4 on CE and EE. Also add the latest changes: - Notifications are only sent to users with access to the project - Draft PR can be disabled - There is a new Rebuild Pipeline button Fixes #511 ## β Checklist - [X] I have tested this change - [ ] This change requires documentation update
## π Description Combines front/backend changes for service account functionality. ## β Checklist - [x] I have tested this change - [x] This change requires documentation update --------- Co-authored-by: Amir Hasanbasic <ahasanbasic@renderedtext.com> Co-authored-by: Amir Hasanbasic <43892661+hamir-suspect@users.noreply.github.com>
β¦519) ## π Description Service accounts do not have `github_repo_host_account` hence we use their semaphore credentials when injecting a workflow request (either manual task run or manual workflow trigger via API) ## β Checklist - [x] I have tested this change - [ ] This change requires documentation update
## π Description Draft PRs that are converted to regular PRs don't trigger builds because the GitHub webhook action `ready_for_review` is not in the list of supported actions in the webhook filter. ## β Checklist - [x] I have tested this change - [ ] This change requires documentation update
β¦ check (#431) ## π Description [_add_people_button](https://github.com/semaphoreio/semaphore/blob/d9a95d1890e5551a67c8071340b065c8bc61d213/front/lib/front_web/templates/people/members/_add_people_button.html.eex#L3) partial already performs required checks. We only need to check if we're on the `on_prem` environment. Introduces `github_user_provider`, `gitlab_user_provider` and `bitbucket_user_provider` feature flags so OS installations can enable user authentication integration with git providers. Introduces `user_repos_access` feature flag for specific setups that need to restrict users from connecting their git provider account to semaphore account. ## β Checklist - [x] I have tested this change - [ ] This change requires documentation update --------- Co-authored-by: Amir Hasanbasic <ahasanbasic@renderedtext.com> Co-authored-by: Amir Hasanbasic <43892661+hamir-suspect@users.noreply.github.com>
β¦Bitbucket worker (#524) ## π Description Currently, the hooks processor does not handle tag deletion webhook events from Bitbucket. This PR adds support for processing that event type and ensures the corresponding branch is archived. Fixes [the task](renderedtext/tasks#8399). ## β Checklist - [x] I have tested this change - [x] ~This change requires documentation update~ N/A
## π Description <!-- Describe your changes in detail --> ## β Checklist - [ ] I have tested this change - [ ] This change requires documentation update
cec945b to
c64dfa8
Compare
Collaborator
Author
|
Apologies if I blew up your inbox as codeowner. I made a mistake π΅βπ« |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Description
I replaced a dead link that was left over from the documentation transition. It now leads to the correct page.
β Checklist