Skip to content

fix(rbac): normalize emails from okta #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
loadez wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(rbac): normalize emails from okta #837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ee/rbac/lib/rbac/okta/saml/payload_parser.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ defmodule Rbac.Okta.Saml.PayloadParser do
email = esaml_assertion(assertion, :subject) |> esaml_subject(:name)
attributes = esaml_assertion(assertion, :attributes) |> construct_attributes_map()

{:ok, to_string(email), attributes}
{:ok, email |> to_string |> String.downcase(), attributes}
end
end

Expand Down
2 changes: 1 addition & 1 deletion ee/rbac/lib/rbac/repo/okta_user.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ defmodule Rbac.Repo.OktaUser do
payload["emails"]
|> Enum.find(fn e -> e["primary"] == true end)

email["value"]
email["value"] |> String.downcase()
end

def connect_user(okta_user, user_id) do
Expand Down
2 changes: 1 addition & 1 deletion ee/rbac/lib/rbac/repo/saml_jit_user.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ defmodule Rbac.Repo.SamlJitUser do
integration_id: integration.id,
org_id: integration.org_id,
attributes: attributes,
email: email,
email: String.downcase(email),
state: :pending
}
end
Expand Down