Skip to content

Commit

Permalink
Fix display for run runtime when run is running (#721)
Browse files Browse the repository at this point in the history
Before:
<img width="140" alt="Screenshot 2023-04-07 at 8 07 29 AM"
src="https://user-images.githubusercontent.com/7181589/230643997-f2be76b3-6211-467b-bfcd-4ae840aa03bb.png">

After:
<img width="99" alt="Screenshot 2023-04-07 at 9 28 48 AM"
src="https://user-images.githubusercontent.com/7181589/230644016-3036fc03-34ad-47f4-9ebb-3941ce2a81a8.png">

Testing
-------
```
$ make ui
$ serve-dev
$ bazel run sematic/examples/testing_pipeline:__main__ -- --cloud --detach --sleep 10000
```
Look at run while running, look at completed/canceled/cloned runs
  • Loading branch information
augray authored Apr 7, 2023
1 parent 896608e commit a65d104
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sematic/ui/packages/main/src/components/RunTime.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export function RunTime(props: { run: Run; prefix?: string }) {
let endTimeString = run.failed_at || run.resolved_at;
if (endTimeString) {
endedAt = new Date(endTimeString);
} else {
} else if (!["CREATED", "SCHEDULED", "RAN", "RETRYING"].includes(run.future_state) ){
return <UnkownRunTime />;
}

Expand Down

0 comments on commit a65d104

Please sign in to comment.