Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle IntCastingNaNError on rematched_updated_pks #8

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

jjh-kim
Copy link
Contributor

@jjh-kim jjh-kim commented Jul 25, 2024

IntCastingNaNError was raised when running rematched_updated_pks on nullable int columns when running with CrossClusterBaseOperation class.
The error occurs on line 248 when updating dest_df’s type to match source_df‘s type.
Since this error indicates differences between dest_df and source_df, we’ve added a try-except block to return an empty set when this error occurs.

@jjh-kim jjh-kim merged commit 60dda9e into develop Jul 25, 2024
2 checks passed
@jjh-kim jjh-kim added the bug Something isn't working label Jul 25, 2024
@jjh-kim jjh-kim deleted the bugfix/handle-int-casting-nan-error branch July 25, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant