fix: added url parsing from data attributes#62
Merged
Lullabyq merged 4 commits intosendsay-ru:masterfrom Feb 9, 2026
Merged
Conversation
✅ Deploy Preview for sendsay-forms ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
aleksnick
approved these changes
Feb 6, 2026
Lullabyq
reviewed
Feb 6, 2026
src/classes/ConditionWatcher.js
Outdated
| const clickTrigger = new ClickTrigger(); | ||
| clickTrigger.watch((attr) => { | ||
| if (attr === `${this.login}/${this.formId}`) { | ||
| if (attr.includes(`${this.login}/${this.formId}`)) { |
Contributor
There was a problem hiding this comment.
а зачем это изменение,
просто я представляю что у какого-то клиента есть 2 встроенные формы одна с id 1 а другая с 11
и проверка attr.includes(x_2212313/1) выдаст true для обоих дивов
я кончено не знаю что делает ConditionWatcher но мне страшно от таких изменений
Contributor
Author
There was a problem hiding this comment.
согласен, заменил на регулярку
Lullabyq
reviewed
Feb 6, 2026
src/classes/EmbeddedFormWatcher.js
Outdated
|
|
||
| try { | ||
| // eslint-disable-next-line compat/compat | ||
| url = new URL(formId).toString(); |
Contributor
There was a problem hiding this comment.
а у нас в formId есть полноценный урл или почему это является фиксом проблемы?
Contributor
Author
There was a problem hiding this comment.
да, у некоторых пользователей в урл формы подставляется их домен и мы в интерфейсе апки выводим его в дата атрибуте
Lullabyq
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Проблема с отображением встроенной формы
fibery