Skip to content

Fixed issue with excel matching #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fabiocat93 merged 1 commit into from
Nov 10, 2025
Merged

Fixed issue with excel matching #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sailsprep/BIDS_convertor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1012,7 +1012,7 @@ def process_single_video(
annotation_df["ID"].astype(str) == str(participant_id)
]
mask = (
participant_excel["FileName"].str.split(".").str[0]
participant_excel["FileName"].str.rsplit(".", n=1).str[0]
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This is a great fix for handling filenames with multiple dots. However, the same issue appears to exist in another part of the file. The determine_session_from_excel function also uses participant_excel["FileName"].str.split(".").str[0] on line 302. To ensure consistency and fully resolve the bug, you should apply this rsplit logic there as well.

== filename_without_extension
)
video_excel = participant_excel[mask]
Expand Down