-
Notifications
You must be signed in to change notification settings - Fork 4
cllm integration design doc #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @puja-trivedi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a comprehensive design document detailing the proposed integration of the Claim LLM (CLLM) tool. The primary objective is to establish a robust pipeline for extracting and evaluating scientific claims from research papers using large language models, and subsequently ingesting this structured data into a knowledge graph. This foundational work aims to enhance the system's capability for automated scientific claim verification and analysis, paving the way for advanced features and broader application within the StructSense framework. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a design document for integrating the CLLM tool. The document is well-structured and clearly outlines the overview, MVP, future enhancements, and architecture. My review includes a couple of minor formatting suggestions to improve the readability and correctness of the markdown file, particularly in the output results table.
Removed trailing space in the 'MVP' heading. Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
corrected the table formatting for consistency and proper rendering. Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
updated google drive links for output
| 3. **Peer Review Evaluation**: Group claims based on peer review commentary | ||
| 4. **Compare Results**: Compare LLM and peer review evaluations | ||
|
|
||
| ## MVP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@puja-trivedi How does this align with StructSense? The design document doesn't make clear on how it will be integrated with the StructSense. Also, what is it that CLLM does differently, is it the prompt based? If yes, can't we just incorporate those prompts? If not, can we use CLLM as tool in StructSense or the core components as tools?
Please remember, we have the extraction pipeline in theStructSense already.
| 4. **Knowledge Graph Ingestion**: Ingest the processed outputs into the knowledge graph for downstream applications. | ||
| ### Todo: | ||
| 1. Add PDF Parsing Layer to extract text from PDFs and feed it into the CLLM workflow. | ||
| 2. Implement output processing to filter and format CLLM outputs for knowledge graph ingestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@puja-trivedi It looks like you're thinking from the independent application, is it so?
|
|
||
| ## Future Enhancements | ||
| - **Peer Review Integration**: Incorporate the peer review evaluation by working with domain-experts to annotate claims and evidence. This will allow us to compare LLM evaluations with human expert assessments. | ||
| - **UI Development**: Develop a user-friendly interface for interacting with the CLLM tool. This could include features for uploading papers, viewing extracted claims, evaluating claims, and visualizing the comparison between LLM and peer review evaluations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The UI development should be the part of the BrainKB UI as it integrates different application. I believe this design document here should only focus on how it will be integrated with StructSense.
tekrajchhetri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the comments below.
tekrajchhetri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the comments below.
No description provided.