Fixed ios keychain dump command to correctly return keychain data #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heya thanks for the PR, this one was my mistake when we did the version bumping. I have already added this fix in #698: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ios keychain dumpcommand currently does not return keychain items as expected. This problem arises because the concatenation and filtering operation on thekeyChainDataarray at line 114 inagent/src/ios/keychain.tsgenerates a new array without updating thekeyChainDatareference. As a result, theenumerateKeychainfunction always returns an emptyIKeychainData[]object.This PR addresses the problem by ensuring that the concatenated and filtered data is directly assigned to the
keyChainDataarray. With this change, the function now returns the correct keychain query results.Special thanks to MWR CyberSec for providing the time and opportunity to investigate and implement this fix.