Skip to content

Conversation

@Jean-Beru
Copy link
Contributor

Q A
Gotenberg API version ? 8.x
Bug fix ? yes
New feature ? no
BC break ? maybe
Issues

Description

Fix assertion on form DataPart files by adding a test on its name.

⚠️ Is it considered as a BC break since CI may fail after this fix. If so, we could do that before next major?

if ($part->getContentType() === $contentType && $body instanceof File && $body->getPath() === Path::canonicalize($path)) {
    if ($part->getName() !== $name) {
        // warn
    }
    $this->addToAssertionCount(1);
}

@Neirda24
Copy link
Contributor

Neirda24 commented Dec 4, 2025

IMO if it was the intended behavior it passes the BC layer

@Jean-Beru
Copy link
Contributor Author

IMO if it was the intended behavior it passes the BC layer

I agree 🙂

@Jean-Beru Jean-Beru added the bug Something isn't working label Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants