-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New examples #272
New examples #272
Conversation
(Report jobs are failing because no previous versions of these examples were found to compare the memory, kinda ironic!) |
Start to sound good! Here are some demo sounds (recording straight from an UNO R3): Filter_envelope:Filter_envelope-converted.mp4RingModulatorRingModulator-converted.mp4The Filter envelope does not show in my list of Arduino examples, I do not understand why. The RM does work well, if someone has an idea... |
Hi Tom, looking and sounding good. Did you get the Filter showing up in examples yet? I don't see any obvious clues... |
It would be good to add them to the examples page on the site, too. |
Yes indeed, I will try to do that! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only had a cursory glance. A few very minor comments.
Mozzi is licensed under the GNU Lesser General Public Licence (LGPL) Version 2.1 or later. | ||
*/ | ||
|
||
#define MOZZI_CONTROL_RATE 64 // Hz, powers of 2 are most reliable; 64 Hz is actually the default, but shown here, for clarity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest to remove this line for simplicity.
uint8_t ring_mod_amount, smoothed_ring_mod_amount; | ||
|
||
UFix<8, 0> notes[4] = { 40 - 12, 52 - 12, 28 - 12, 30 - 12 }; // note played. Because of the ringModulation the oscillator is called *two times* | ||
// hence produces a note which an octave to high, so we compensate for that here (12 midi notes makes an octave). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing "is"
|
||
void setup() { | ||
//Serial.begin(9600); // for Teensy 3.1, beware printout can cause glitches | ||
Serial.begin(115200); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest to remove Serial, here.
} | ||
|
||
|
||
unsigned int duration, attack, decay, sustain, release_ms; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused?
Good eye as always @tfry-git! Will correct soon, thanks! |
Ok, I implemented the changes. I also renamed the RingModulator example, as, actually, this is not really a RM, but more a self modulator. The two examples shows in the IDE (cause was an hidden file locally). @sensorium For the website, I have to say I do not have a very clear view how all that is done… Are you using the scripts in extras/devscripts to automate the process of having all the examples copied to the gh-pages and generate the audio samples? |
Hi Tom, yes, I was using those scripts when Mozzi was developing, to check that all the examples worked locally after code changes and keep the pages in sync. But with the checks you and Thomas have set up on Github and the more orderly development process, the scripts don't seem necessary anymore (I wonder whether to remove them to save confusion?). I'd suggest to just edit the markdown for the webpage directly - what do you think? |
Yes probably! |
I haven't made any Github workflows, if that's what you mean. |
Merging. Will add the needed doc soon in another PR! |
Just to confirm, the changes made to I'll try to use that to regenerate the page, looks like there is nothing depending on the local architecture of the files in this one (which is not the case of |
Yes, I have used an existing script (and probably it was extras/devscripts/mozzi_generate_examples_page_buttons.sh) for updating the examples page. |
Thanks! |
Adding two new examples:
Still work in progress, the former does not sound synthy enough to my taste, and the later is very basic.