Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compilation for Teensy2 #277

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

tomcombriat
Copy link
Collaborator

Looks like a typo, but do not have the hardware to try…

@tfry-git
Copy link
Collaborator

Yes, clearly a typo. But no, I don't have a Teensy board, either.

@sensorium Could you enable the permission "Send write tokens to workflows from fork pull requests" as per https://github.com/arduino/report-size-deltas?tab=readme-ov-file#run-from-a-scheduled-workflow ?

@tfry-git
Copy link
Collaborator

And here's the offending commit introducing the error: 51ae09a

@tomcombriat
Copy link
Collaborator Author

Alright. If you agree I'm in favour of merging, and worse case changing it again if it does not work as intended: that only affects Teensy2 and at least it compiles now…

@sensorium
Copy link
Owner

permission "Send write tokens to workflows from fork pull requests" as per https://github.com/arduino/report-size-deltas?tab=readme-ov-file#run-from-a-scheduled-workflow ?

Hi @tfry-git , I followed the link from that page to "Send write tokens to workflows from fork pull requests", and that option seems to be only available for private repos? I couldn't find that permission in my settings under actions/general... should I look somewhere else?

@tfry-git
Copy link
Collaborator

permission "Send write tokens to workflows from fork pull requests" as per https://github.com/arduino/report-size-deltas?tab=readme-ov-file#run-from-a-scheduled-workflow ?

Hi @tfry-git , I followed the link from that page to "Send write tokens to workflows from fork pull requests", and that option seems to be only available for private repos? I couldn't find that permission in my settings under actions/general... should I look somewhere else?

Hm, I can't seem to find the option, either. Sorry for sending you to a dead end.

@tomcombriat tomcombriat merged commit 93a51c0 into sensorium:master Sep 24, 2024
12 of 13 checks passed
@tomcombriat tomcombriat deleted the fix/Teensy2 branch September 24, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants