[Feat/modal]: 메인페이지 모달 중복 에러 수정 및 페이지 이동 시 모달 닫힘 기능 구현#50
Merged
Conversation
SeanKim05
approved these changes
Jan 27, 2025
Contributor
SeanKim05
left a comment
SeanKim05
left a comment
There was a problem hiding this comment.
고생하셨습니다! 닫기 상태가 전역으로 관리되어서 더 좋은거 같아요!
fullkeem
approved these changes
Jan 27, 2025
Collaborator
fullkeem
left a comment
fullkeem
left a comment
There was a problem hiding this comment.
closeModal로 처리하니 훨씬 깔끔하고 좋네요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 PR 제목
--- 메인페이지 모달 중복 에러 수정
📌 변경 사항
🚀 작업 목적
🔄 관련 이슈
✅ 체크리스트
🧐 중점적으로 리뷰받고 싶은 부분
🤝 PR 리뷰어에게 요청사항