Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The c line in the media description should come after the m line. #196

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/sdp.c
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ void sdp_reset(Sdp* sdp) {

void sdp_append_h264(Sdp* sdp) {
sdp_append(sdp, "m=video 9 UDP/TLS/RTP/SAVPF 96 102");
sdp_append(sdp, "c=IN IP4 0.0.0.0");
sdp_append(sdp, "a=rtcp-fb:102 nack");
sdp_append(sdp, "a=rtcp-fb:102 nack pli");
sdp_append(sdp, "a=fmtp:96 profile-level-id=42e01f;level-asymmetry-allowed=1");
Expand All @@ -36,45 +37,44 @@ void sdp_append_h264(Sdp* sdp) {
sdp_append(sdp, "a=ssrc:1 cname:webrtc-h264");
sdp_append(sdp, "a=sendrecv");
sdp_append(sdp, "a=mid:video");
sdp_append(sdp, "c=IN IP4 0.0.0.0");
sdp_append(sdp, "a=rtcp-mux");
}

void sdp_append_pcma(Sdp* sdp) {
sdp_append(sdp, "m=audio 9 UDP/TLS/RTP/SAVP 8");
sdp_append(sdp, "c=IN IP4 0.0.0.0");
sdp_append(sdp, "a=rtpmap:8 PCMA/8000");
sdp_append(sdp, "a=ssrc:4 cname:webrtc-pcma");
sdp_append(sdp, "a=sendrecv");
sdp_append(sdp, "a=mid:audio");
sdp_append(sdp, "c=IN IP4 0.0.0.0");
sdp_append(sdp, "a=rtcp-mux");
}

void sdp_append_pcmu(Sdp* sdp) {
sdp_append(sdp, "m=audio 9 UDP/TLS/RTP/SAVP 0");
sdp_append(sdp, "c=IN IP4 0.0.0.0");
sdp_append(sdp, "a=rtpmap:0 PCMU/8000");
sdp_append(sdp, "a=ssrc:5 cname:webrtc-pcmu");
sdp_append(sdp, "a=sendrecv");
sdp_append(sdp, "a=mid:audio");
sdp_append(sdp, "c=IN IP4 0.0.0.0");
sdp_append(sdp, "a=rtcp-mux");
}

void sdp_append_opus(Sdp* sdp) {
sdp_append(sdp, "m=audio 9 UDP/TLS/RTP/SAVP 111");
sdp_append(sdp, "c=IN IP4 0.0.0.0");
sdp_append(sdp, "a=rtpmap:111 opus/48000/2");
sdp_append(sdp, "a=ssrc:6 cname:webrtc-opus");
sdp_append(sdp, "a=sendrecv");
sdp_append(sdp, "a=mid:audio");
sdp_append(sdp, "c=IN IP4 0.0.0.0");
sdp_append(sdp, "a=rtcp-mux");
}

void sdp_append_datachannel(Sdp* sdp) {
sdp_append(sdp, "m=application 50712 UDP/DTLS/SCTP webrtc-datachannel");
sdp_append(sdp, "c=IN IP4 0.0.0.0");
sdp_append(sdp, "a=mid:datachannel");
sdp_append(sdp, "a=sctp-port:5000");
sdp_append(sdp, "c=IN IP4 0.0.0.0");
sdp_append(sdp, "a=max-message-size:262144");
}

Expand Down