Properly handle ERR_REQUIRE_ASYNC_MODULE
#470
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent Node.js versions throw `ERR_REQUIRE_ASYNC_MODULE` instead of `ERR_REQUIRE_ESM` if `require()` is used to import a module with top- level await.
Author
|
@seppevs can you please take a look? Without this fix, migrate-mongo is unusable on newer Node.js versions when top-level await is involved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent Node.js versions throw
ERR_REQUIRE_ASYNC_MODULEinstead ofERR_REQUIRE_ESMifrequire()is used to import a module with top-level await.Minimal reproduction: https://github.com/mxxk-examples/migrate-mongo-async-esm-issue
Fixes #469 (by making a superset of the changes in that PR).
Potentially related to #458.
Checklist
npm testpasses and has 100% coverage