Update pipeline optimization K8s deployment steps #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for seqera-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@swampie, I wasn't sure who the best person for this review was so I tagged you. Thanks! |
justinegeffen
added
1. Editor review
platform_versioned_docs/version-24.1/enterprise/_templates/k8s/configmap.yml
Show resolved
Hide resolved
jason-seqera
force-pushed
the
EDU-256-configmap-groundswell-k8s
branch
from
397308e
to
4477a85
Compare
justinegeffen
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the required variables for the K8s config map. And the missing step from the Docker configuration.
Additionally, this differentiates steps for the database grant commands and removes steps that are not user action.
If this makes sense, should be applied to both sets of Docker instructions as well.