Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in content need for tests to pass on Azure #25

Closed
wants to merge 0 commits into from

Conversation

vsmalladi
Copy link
Contributor

@vsmalladi vsmalladi commented Apr 18, 2024

Closes #24

Copy link
Collaborator

@adamrtalbot adamrtalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree in principle but I think we should catch an empty file as well. Even if it breaks Azure 😆 , that is after all, the purpose of this pipeline.

main.nf Outdated
@@ -21,7 +21,7 @@ process TEST_CREATE_FILE {
path("*.txt"), emit: outfile

"""
touch test.txt
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a TEST_CREATE_EMPTY_FILE to go with it?

@adamrtalbot adamrtalbot linked an issue Apr 18, 2024 that may be closed by this pull request
@adamrtalbot
Copy link
Collaborator

Tests should now pass. They had drifted out of sync a bit!

main.nf Outdated
Comment on lines 256 to 257
TEST_CREATE_EMPTY_FILE()
TEST_CREATE_FOLDER()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TEST_CREATE_EMPTY_FILE()
TEST_CREATE_FOLDER()
TEST_CREATE_EMPTY_FILE()
TEST_CREATE_FOLDER()

Copy link
Collaborator

@adamrtalbot adamrtalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vsmalladi!

@adamrtalbot adamrtalbot changed the title Add in content need for tests to pass on azure Closes #24 Add in content need for tests to pass on Azure Apr 19, 2024
@adamrtalbot
Copy link
Collaborator

Errr not sure what happened here but I appeared to kill the PR? I've never managed that before! Reopened as #27

@vsmalladi
Copy link
Contributor Author

Oh intersting. Anything i need to change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add file contents
2 participants