-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in content need for tests to pass on Azure #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree in principle but I think we should catch an empty file as well. Even if it breaks Azure 😆 , that is after all, the purpose of this pipeline.
main.nf
Outdated
@@ -21,7 +21,7 @@ process TEST_CREATE_FILE { | |||
path("*.txt"), emit: outfile | |||
|
|||
""" | |||
touch test.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a TEST_CREATE_EMPTY_FILE
to go with it?
Tests should now pass. They had drifted out of sync a bit! |
main.nf
Outdated
TEST_CREATE_EMPTY_FILE() | ||
TEST_CREATE_FOLDER() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TEST_CREATE_EMPTY_FILE() | |
TEST_CREATE_FOLDER() | |
TEST_CREATE_EMPTY_FILE() | |
TEST_CREATE_FOLDER() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vsmalladi!
Errr not sure what happened here but I appeared to kill the PR? I've never managed that before! Reopened as #27 |
Oh intersting. Anything i need to change? |
Closes #24