Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve logic to respect cli and dryrun flags with info #156

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

ejseqera
Copy link
Member

@ejseqera ejseqera commented Jul 31, 2024

Fixes #151 to use Tw CLI options with --cli and also --dryrun when invoking the info method.

Test with:

$ seqerakit --info --cli="--url=https://cloud.seqera.io/api"

Should return:

INFO:root: Running command: tw --url=https://cloud.seqera.io/api info
Details
    -------------------------+-----------------------------
     Tower API endpoint      | https://cloud.seqera.io/api 
     Tower API version       | 1.25.0                      
     Tower version           | 24.2.0_cycle20              
     CLI version             | 0.9.2 (39a2ec6)             
     CLI minimum API version | 1.15                        
     Authenticated user      | esha-joshi                  

    System health status
    ---------------------------------------+----
     Remote API server connection check    | OK 
     Tower API version check               | OK 
     Authentication API credential's token | OK

And with --dryrun:

$ seqerakit --info --cli="--url=https://cloud.seqera.io/api" --dryrun
INFO:root:DRYRUN: Running command tw --url=https://cloud.seqera.io/api info

@ejseqera ejseqera requested a review from adamrtalbot July 31, 2024 21:00
Copy link
Collaborator

@adamrtalbot adamrtalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this incorporated into #157?

@ejseqera
Copy link
Member Author

ejseqera commented Aug 1, 2024

@adamrtalbot Yes it is now.

@ejseqera ejseqera merged commit d20f672 into dev Aug 2, 2024
2 checks passed
@ejseqera ejseqera deleted the 151-info-fix-cli-flag branch August 2, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants