Recursively delete from yaml #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still need to add tests :/ |
ejseqera
commented
Oct 6, 2023
| @@ -78,10 +78,10 @@ You will need to have an account on Nextflow Tower (see [Plans and pricing](http | |||
| twkit hello-world-config.yml | |||
| ``` | |||
|
|
|||
| <b>Note</b>: The Tower CLI expects to connect to a Tower instance that is secured by a TLS certificate. If your Tower instance does not present a certificate, you will need to qualify and run your `tw` commands with the `--insecure` flag. For example: | |||
| <b>Note</b>: The Tower CLI expects to connect to a Tower instance that is secured by a TLS certificate. If your Tower instance does not present a certificate, you will need to qualify and run your `tw` commands with `--cli` followed by the `--insecure` flag. For example: | |||
There was a problem hiding this comment.
@adamrtalbot I think this is quite ugly to have to provide any additional tw cli options after --cli to twkit so it can parse these correctly to the _tw_run() method in the Tower() class and not confuse it with twkit specific arguments such as --delete and --dryrun but I am not sure how else to handle this. Any suggestions?
There was a problem hiding this comment.
You could quote after the --cli? So --cli '--insecure'. Not great. I'll have to think about this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for a
--deleteflag where if supplied totwkitwith YAML(s), will recursively delete all resources instead of create them. For example, if you create organization -> workspace -> team -> credentials -> compute-env -> pipeline. When supplyingtwkit file.yaml --delete, the tool will delete pipeline -> compute-env -> credentials -> team -> workspace -> organization.Leverages existing functionality we had for deleting resources in
overwrite.py, specifically thedelete_resource()method called inhandle_overwrite.