Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken dryrun option #58

Merged
merged 5 commits into from
Oct 12, 2023
Merged

Fix broken dryrun option #58

merged 5 commits into from
Oct 12, 2023

Conversation

ejseqera
Copy link
Member

Re #49 where --dryrun returns JSON errors. Additionally adds test for --dryrun and another for CLI args like custom SSL cert stores.

@ejseqera ejseqera self-assigned this Oct 12, 2023
laramiellindsey
laramiellindsey reviewed Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@laramiellindsey laramiellindsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add information on what to do with multiple cli args in README.md

Remove "it" line 94 of README.md

ejseqera
ejseqera commented Oct 12, 2023
View reviewed changes
Copy link
Member Author

@ejseqera ejseqera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix README w/ Laramie's comments

README.md Outdated Show resolved Hide resolved
@ejseqera ejseqera merged commit 9505303 into dev Oct 12, 2023
@ejseqera ejseqera deleted the 49-broken-dryrun-option branch October 12, 2023 21:53
@ejseqera ejseqera mentioned this pull request Oct 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laramiellindsey laramiellindsey laramiellindsey approved these changes

Assignees

@ejseqera ejseqera

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ejseqera @laramiellindsey