Improve log statuses for health checks #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaimeSeqLabs
requested review from
jordeu,
tcrespog and
weronikasosnowskaseqera
tcrespog
approved these changes
Aug 18, 2023
jordeu
approved these changes
Aug 21, 2023
|
Perfect - thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simple health check status message rename from UNDEFINED to SKIPPED.
Closes #248
Guidelines for testing
Health check against a non-existent API URL
tw -u https://localhost:9999 info:Detail fields that cannot be retrieved stay as UNDEFINED and the skipped health checks show as SKIPPED.