Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve container credentials retrieval matching container repository names #278

Open
wants to merge 48 commits into
base: master
Choose a base branch
from

Conversation

munishchouhan
Copy link
Member

@munishchouhan munishchouhan commented Aug 8, 2023

  1. wave should support repository credential validation
  2. Wave should choose the best matching credentials from the tower for a give registry/repository name

@munishchouhan munishchouhan marked this pull request as draft August 8, 2023 19:39
@munishchouhan munishchouhan self-assigned this Aug 9, 2023
@munishchouhan munishchouhan marked this pull request as ready for review August 16, 2023 17:03
…er-credentials-retrieval-matching-container-repository-names
…er-credentials-retrieval-matching-container-repository-names
…er-credentials-retrieval-matching-container-repository-names
…er-credentials-retrieval-matching-container-repository-names
…er-credentials-retrieval-matching-container-repository-names
…er-credentials-retrieval-matching-container-repository-names
@marcodelapierre
Copy link
Contributor

@pditommaso pinging you on this one - can you provide an output on any dependency that is holding this PR? thank you :-)

munishchouhan and others added 9 commits November 27, 2023 11:31
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
@pditommaso pditommaso force-pushed the 224-improve-container-credentials-retrieval-matching-container-repository-names branch from 1a7df00 to 4fbf3bb Compare December 21, 2023 16:04
Copy link

gitguardian bot commented Jul 9, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
8498070 Triggered Username Password f8eed91 src/test/groovy/io/seqera/wave/auth/RegistryCredentialsProviderTest.groovy View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

munishchouhan and others added 3 commits August 30, 2024 11:28
Signed-off-by: munishchouhan <hrma017@gmail.com>
Signed-off-by: munishchouhan <hrma017@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve container credentials retrieval matching container repository names
3 participants