Replace redb with parity-db

It still has much better compile times yet doesn't block when creating multiple
transactions. It also is actively maintained and doesn't grow our tree. The MPT
aspects are irrelevant.

common/db/Cargo.toml

@@ -14,9 +14,9 @@ all-features = true
 rustdoc-args = ["--cfg", "docsrs"]
 
 [dependencies]
-redb = { version = "1", default-features = false, optional = true }
+parity-db = { version = "0.4", default-features = false, optional = true }
 rocksdb = { version = "0.21", default-features = false, features = ["lz4"], optional = true }
 
 [features]
-redb = ["dep:redb"]
+parity-db = ["dep:parity-db"]
 rocksdb = ["dep:rocksdb"]

common/db/src/lib.rs

@@ -9,10 +9,10 @@ mod rocks;
 #[cfg(feature = "rocksdb")]
 pub use rocks::{RocksDB, new_rocksdb};
 
-#[cfg(feature = "redb")]
-mod redb;
-#[cfg(feature = "redb")]
-pub use redb::{Redb, new_redb};
+#[cfg(feature = "parity_db")]
+mod parity_db;
+#[cfg(feature = "parity_db")]
+pub use parity_db::{ParityDb, new_parity_db};
 
 /// An object implementing get.
 pub trait Get {

common/db/src/parity_db.rs

@@ -0,0 +1,41 @@
+use std::sync::Arc;
+
+pub use ::parity_db::Db as ParityDb;
+use ::redb::*;
+
+use crate::*;
+
+pub struct Transaction<'a>(&'a Arc<ParityDb>, Vec<(u8, Vec<u8>, Option<Vec<u8>>)>);
+
+impl Get for Transaction<'_> {
+  fn get(&self, key: impl AsRef<[u8]>) -> Option<Vec<u8>> {
+    self.0.get(key)
+  }
+}
+impl DbTxn for Transaction<'_> {
+  fn put(&mut self, key: impl AsRef<[u8]>, value: impl AsRef<[u8]>) {
+    self.1.push((0, key.as_ref().to_vec(), Some(value.as_ref().to_vec())))
+  }
+  fn del(&mut self, key: impl AsRef<[u8]>) {
+    self.1.push((0, key.as_ref().to_vec(), None))
+  }
+  fn commit(self) {
+    self.0.commit(self.1).unwrap()
+  }
+}
+
+impl Get for Arc<ParityDb> {
+  fn get(&self, key: impl AsRef<[u8]>) -> Option<Vec<u8>> {
+    ParityDb::get(&*self, 0, key.as_ref()).unwrap()
+  }
+}
+impl Db for Arc<ParityDb> {
+  type Transaction<'a> = Transaction<'a>;
+  fn txn(&mut self) -> Self::Transaction<'_> {
+    Transaction(self, vec![])
+  }
+}
+
+pub fn new_parity_db(path: &str) -> Arc<ParityDb> {
+  Arc::new(ParityDb::open_or_crate(Options::with_columns(path, 1)).unwrap())
+}

coordinator/Cargo.toml

@@ -57,5 +57,5 @@ sp-application-crypto = { git = "https://github.com/serai-dex/substrate", defaul
 sp-runtime = { git = "https://github.com/serai-dex/substrate", default-features = false, features = ["std"] }
 
 [features]
-redb = ["serai-db/redb"]
+parity-db = ["serai-db/parity-db"]
 rocksdb = ["serai-db/rocksdb"]

coordinator/src/main.rs

@@ -1200,10 +1200,11 @@ async fn main() {
 
   #[allow(unused_variables, unreachable_code)]
   let db = {
-    #[cfg(all(feature = "redb", feature = "rocksdb"))]
-    panic!("built with redb and rocksdb");
-    #[cfg(all(feature = "redb", not(feature = "rocksdb")))]
-    let db = serai_db::new_redb(&serai_env::var("DB_PATH").expect("path to DB wasn't specified"));
+    #[cfg(all(feature = "parity-db", feature = "rocksdb"))]
+    panic!("built with parity-db and rocksdb");
+    #[cfg(all(feature = "parity-db", not(feature = "rocksdb")))]
+    let db =
+      serai_db::new_parity_db(&serai_env::var("DB_PATH").expect("path to DB wasn't specified"));
     #[cfg(feature = "rocksdb")]
     let db =
       serai_db::new_rocksdb(&serai_env::var("DB_PATH").expect("path to DB wasn't specified"));

message-queue/Cargo.toml

@@ -44,5 +44,5 @@ serai-env = { path = "../common/env" }
 serai-primitives = { path = "../substrate/primitives", features = ["borsh"] }
 
 [features]
-redb = ["serai-db/redb"]
+parity-db = ["serai-db/parity-db"]
 rocksdb = ["serai-db/rocksdb"]

message-queue/src/main.rs

@@ -22,7 +22,7 @@ pub(crate) use crate::messages::*;
 
 pub(crate) use crate::queue::Queue;
 
-#[cfg(all(feature = "redb", not(feature = "rocksdb")))]
+#[cfg(all(feature = "parity-db", not(feature = "rocksdb")))]
 pub(crate) type Db = Arc<serai_db::Redb>;
 #[cfg(feature = "rocksdb")]
 pub(crate) type Db = serai_db::RocksDB;
@@ -166,10 +166,11 @@ async fn main() {
   // Open the DB
   #[allow(unused_variables, unreachable_code)]
   let db = {
-    #[cfg(all(feature = "redb", feature = "rocksdb"))]
-    panic!("built with redb and rocksdb");
-    #[cfg(all(feature = "redb", not(feature = "rocksdb")))]
-    let db = serai_db::new_redb(&serai_env::var("DB_PATH").expect("path to DB wasn't specified"));
+    #[cfg(all(feature = "parity-db", feature = "rocksdb"))]
+    panic!("built with parity-db and rocksdb");
+    #[cfg(all(feature = "parity-db", not(feature = "rocksdb")))]
+    let db =
+      serai_db::new_parity_db(&serai_env::var("DB_PATH").expect("path to DB wasn't specified"));
     #[cfg(feature = "rocksdb")]
     let db =
       serai_db::new_rocksdb(&serai_env::var("DB_PATH").expect("path to DB wasn't specified"));

orchestration/coordinator/Dockerfile

@@ -46,7 +46,7 @@ RUN --mount=type=cache,target=/root/.cargo \
   --mount=type=cache,target=/usr/local/cargo/git \
   --mount=type=cache,target=/serai/target \
   mkdir /serai/bin && \
-  cargo build -p serai-coordinator --features redb && \
+  cargo build -p serai-coordinator --features parity-db && \
   mv /serai/target/debug/serai-coordinator /serai/bin
 FROM debian:bookworm-slim as image
 

orchestration/coordinator/Dockerfile.coordinator

@@ -1,2 +1,2 @@
-  cargo build -p serai-coordinator --features redb && \
+  cargo build -p serai-coordinator --features parity-db && \
   mv /serai/target/debug/serai-coordinator /serai/bin

orchestration/message-queue/Dockerfile

@@ -46,7 +46,7 @@ RUN --mount=type=cache,target=/root/.cargo \
   --mount=type=cache,target=/usr/local/cargo/git \
   --mount=type=cache,target=/serai/target \
   mkdir /serai/bin && \
-  cargo build --features redb -p serai-message-queue && \
+  cargo build --features parity-db -p serai-message-queue && \
   mv /serai/target/debug/serai-message-queue /serai/bin
 FROM debian:bookworm-slim as image
 

orchestration/message-queue/Dockerfile.message-queue

@@ -1,2 +1,2 @@
-  cargo build --features redb -p serai-message-queue && \
+  cargo build --features parity-db -p serai-message-queue && \
   mv /serai/target/debug/serai-message-queue /serai/bin

orchestration/processor/bitcoin/Dockerfile

@@ -46,7 +46,7 @@ RUN --mount=type=cache,target=/root/.cargo \
   --mount=type=cache,target=/usr/local/cargo/git \
   --mount=type=cache,target=/serai/target \
   mkdir /serai/bin && \
-  cargo build --features "binaries redb bitcoin" -p serai-processor && \
+  cargo build --features "binaries parity-db bitcoin" -p serai-processor && \
   mv /serai/target/debug/serai-processor /serai/bin
 FROM debian:bookworm-slim as image
 

orchestration/processor/bitcoin/Dockerfile.processor.bitcoin

@@ -1,2 +1,2 @@
-  cargo build --features "binaries redb bitcoin" -p serai-processor && \
+  cargo build --features "binaries parity-db bitcoin" -p serai-processor && \
   mv /serai/target/debug/serai-processor /serai/bin

orchestration/processor/monero/Dockerfile

@@ -46,7 +46,7 @@ RUN --mount=type=cache,target=/root/.cargo \
   --mount=type=cache,target=/usr/local/cargo/git \
   --mount=type=cache,target=/serai/target \
   mkdir /serai/bin && \
-  cargo build --features "binaries redb monero" -p serai-processor && \
+  cargo build --features "binaries parity-db monero" -p serai-processor && \
   mv /serai/target/debug/serai-processor /serai/bin
 FROM debian:bookworm-slim as image
 

orchestration/processor/monero/Dockerfile.processor.monero

@@ -1,2 +1,2 @@
-  cargo build --features "binaries redb monero" -p serai-processor && \
+  cargo build --features "binaries parity-db monero" -p serai-processor && \
   mv /serai/target/debug/serai-processor /serai/bin

processor/Cargo.toml

@@ -79,5 +79,5 @@ ed25519 = ["dalek-ff-group", "frost/ed25519"]
 monero = ["ed25519", "monero-serai", "serai-client/monero"]
 
 binaries = ["env_logger", "serai-env", "messages", "message-queue"]
-redb = ["serai-db/redb"]
+parity-db = ["serai-db/parity-db"]
 rocksdb = ["serai-db/rocksdb"]

processor/src/main.rs

@@ -681,10 +681,11 @@ async fn main() {
 
   #[allow(unused_variables, unreachable_code)]
   let db = {
-    #[cfg(all(feature = "redb", feature = "rocksdb"))]
-    panic!("built with redb and rocksdb");
-    #[cfg(all(feature = "redb", not(feature = "rocksdb")))]
-    let db = serai_db::new_redb(&serai_env::var("DB_PATH").expect("path to DB wasn't specified"));
+    #[cfg(all(feature = "parity-db", feature = "rocksdb"))]
+    panic!("built with parity-db and rocksdb");
+    #[cfg(all(feature = "parity-db", not(feature = "rocksdb")))]
+    let db =
+      serai_db::new_parity_db(&serai_env::var("DB_PATH").expect("path to DB wasn't specified"));
     #[cfg(feature = "rocksdb")]
     let db =
       serai_db::new_rocksdb(&serai_env::var("DB_PATH").expect("path to DB wasn't specified"));