New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid duplication in ID module #3024

Merged

GnomedDev merged 1 commit into serenity-rs:current from GnomedDev:smaller-id

Nov 11, 2024

Member

GnomedDev commented Nov 11, 2024

This PR:

Moves the #[repr(packed)] into an InnerId, to avoid duplicating said attribute and to open the door for casting &Id to &Id in future.
Moves the snowflake serde module into just InnerId.
Generates the ID newtypes via the macro, cleaning up the module significantly

There should be no publicly facing difference for this, purely internal changes.


          Avoid duplication in ID module

effeb14

github-actions bot added the model label

arqunis approved these changes

View reviewed changes

arqunis added the enhancement label

GnomedDev merged commit 57f66f7 into serenity-rs:current

22 checks passed

GnomedDev deleted the smaller-id branch

November 11, 2024 21:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement model